From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
"Richard W . M . Jones" <rjones@redhat.com>
Subject: Re: [PATCH v3 1/2] docs: show how to spawn qemu-storage-daemon with fd passing
Date: Mon, 1 Mar 2021 18:27:53 +0000 [thread overview]
Message-ID: <YD0yKX1Yaxv7w80N@redhat.com> (raw)
In-Reply-To: <20210301172728.135331-2-stefanha@redhat.com>
On Mon, Mar 01, 2021 at 05:27:27PM +0000, Stefan Hajnoczi wrote:
> The QMP monitor, NBD server, and vhost-user-blk export all support file
> descriptor passing. This is a useful technique because it allows the
> parent process to spawn and wait for qemu-storage-daemon without busy
> waiting, which may delay startup due to arbitrary sleep() calls.
>
> This Python example is inspired by the test case written for libnbd by
> Richard W.M. Jones <rjones@redhat.com>:
> https://gitlab.com/nbdkit/libnbd/-/commit/89113f484effb0e6c322314ba75c1cbe07a04543
>
> Thanks to Daniel P. Berrangé <berrange@redhat.com> for suggestions on
> how to get this working. Now let's document it!
>
> Reported-by: Richard W.M. Jones <rjones@redhat.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> v2:
> * Use /var/run/qmp.sock instead of /tmp/qmp-$PID.sock to prevent
> security issues with world-writeable directories [Rich, Daniel]
> ---
> docs/tools/qemu-storage-daemon.rst | 42 ++++++++++++++++++++++++++++--
> 1 file changed, 40 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-03-01 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 17:27 [PATCH v3 0/2] docs: show how to spawn qemu-storage-daemon with fd passing Stefan Hajnoczi
2021-03-01 17:27 ` [PATCH v3 1/2] " Stefan Hajnoczi
2021-03-01 18:27 ` Daniel P. Berrangé [this message]
2021-03-01 17:27 ` [PATCH v3 2/2] docs: replace insecure /tmp examples in qsd docs Stefan Hajnoczi
2021-03-01 18:28 ` Daniel P. Berrangé
2021-03-01 19:00 ` Richard W.M. Jones
2021-03-03 9:36 ` [PATCH v3 0/2] docs: show how to spawn qemu-storage-daemon with fd passing Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD0yKX1Yaxv7w80N@redhat.com \
--to=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).