From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FE15C433E0 for ; Wed, 3 Mar 2021 10:16:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0519564E99 for ; Wed, 3 Mar 2021 10:16:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0519564E99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHOY4-000814-0A for qemu-devel@archiver.kernel.org; Wed, 03 Mar 2021 05:16:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHOU4-0003UW-N9 for qemu-devel@nongnu.org; Wed, 03 Mar 2021 05:12:00 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52022) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHOU3-0008Ks-13 for qemu-devel@nongnu.org; Wed, 03 Mar 2021 05:12:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614766318; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AeUcyIGJ6XT7UxuMYpuQ9REScW1nqNumPESbeXZhHoc=; b=NyxmnlgZSlwZbntXLEMe+G9NVDsRSaNmIQQv3zIB2ZWDCV27+kI9Lfe+JNN2Y1OyOBmTI3 5MeRZNdNdh3PSyM07wyNgluofeUIDykWuK/BInu7PKBSZY/Pm21/Wlel/byDixBGCA/FIk 7XUAOnHtcnjjNgCx/59xe/G98ABi9WA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-159-PGhS_zCwMw6tZb7OxzUuyg-1; Wed, 03 Mar 2021 05:11:54 -0500 X-MC-Unique: PGhS_zCwMw6tZb7OxzUuyg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91FD3107ACE6; Wed, 3 Mar 2021 10:11:53 +0000 (UTC) Received: from redhat.com (ovpn-115-145.ams2.redhat.com [10.36.115.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F4325C8B4; Wed, 3 Mar 2021 10:11:48 +0000 (UTC) Date: Wed, 3 Mar 2021 10:11:45 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Gerd Hoffmann Subject: Re: [PATCH 2/3] qapi, audio: respect build time conditions in audio schema Message-ID: References: <20210302175524.1290840-1-berrange@redhat.com> <20210302175524.1290840-3-berrange@redhat.com> <20210303070059.sx5t3y3d76f2aflo@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: <20210303070059.sx5t3y3d76f2aflo@sirius.home.kraxel.org> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Michael Roth , qemu-devel@nongnu.org, Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Mar 03, 2021 at 08:00:59AM +0100, Gerd Hoffmann wrote: > On Tue, Mar 02, 2021 at 05:55:23PM +0000, Daniel P. Berrangé wrote: > > Currently the -audiodev accepts any audiodev type regardless of what is > > built in to QEMU. An error only occurs later at runtime when a sound > > device tries to use the audio backend. > > > > With this change QEMU will immediately reject -audiodev args that are > > not compiled into the binary. The QMP schema will also be introspectable > > to identify what is compiled in. > > Note that audio backends are modularized, so "compiled with > CONFIG_AUDIO_ALSA" doesn't imply "alsa support is available". AFAIK, there's no way to handle this with QAPI schema reporting. We can only conditionalize based on what's available at compile time, not what's installed at runtime. To get runtime info, we would have to introduce an explicit "query-audiodev-types" command where just report the backends that have been installed. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|