From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: vsementsov@virtuozzo.com, qemu-block@nongnu.org,
rjones@redhat.com, tao3.xu@intel.com, armbru@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/4] utils: Enhance testsuite for do_strtosz()
Date: Tue, 23 Feb 2021 17:07:59 +0000 [thread overview]
Message-ID: <YDU2b9P0DQsbAOM7@redhat.com> (raw)
In-Reply-To: <20210211204438.1184395-2-eblake@redhat.com>
On Thu, Feb 11, 2021 at 02:44:35PM -0600, Eric Blake wrote:
> Enhance our testsuite coverage of do_strtosz() to cover some things we
> know that existing users want to continue working (hex bytes), as well
> as some things that accidentally work but shouldn't (hex fractions) or
> accidentally fail but that users want to work (64-bit precision on
> byte values). This includes fixing a typo in the comment regarding
> our parsing near 2^64.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> tests/test-cutils.c | 154 ++++++++++++++++++++++++++++++++++++++++----
> 1 file changed, 143 insertions(+), 11 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-02-23 17:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 20:44 [PATCH v2 0/4] improve do_strtosz precision Eric Blake
2021-02-11 20:44 ` [PATCH v2 1/4] utils: Enhance testsuite for do_strtosz() Eric Blake
2021-02-23 17:07 ` Daniel P. Berrangé [this message]
2021-02-11 20:44 ` [PATCH v2 2/4] utils: Improve qemu_strtosz() to have 64 bits of precision Eric Blake
2021-02-23 17:13 ` Daniel P. Berrangé
2021-02-11 20:44 ` [PATCH v2 3/4] utils: Deprecate hex-with-suffix sizes Eric Blake
2021-02-11 22:59 ` Philippe Mathieu-Daudé
2021-02-23 17:13 ` Daniel P. Berrangé
2021-02-11 20:44 ` [PATCH v2 4/4] utils: Deprecate inexact fractional suffix sizes Eric Blake
2021-02-23 17:20 ` Daniel P. Berrangé
2021-02-24 13:52 ` Eric Blake
2021-02-22 20:19 ` [PATCH v2 0/4] improve do_strtosz precision Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDU2b9P0DQsbAOM7@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=tao3.xu@intel.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).