From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1AD1C433DB for ; Tue, 23 Feb 2021 15:25:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13DDC64E4B for ; Tue, 23 Feb 2021 15:25:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13DDC64E4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEZZR-0003w6-1n for qemu-devel@archiver.kernel.org; Tue, 23 Feb 2021 10:25:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEZX3-0001Ix-JD for qemu-devel@nongnu.org; Tue, 23 Feb 2021 10:23:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEZX1-00010f-GE for qemu-devel@nongnu.org; Tue, 23 Feb 2021 10:23:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614093802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wuhyWa5bIC3RTP2C7gnxTzcVj5wGpRDvBOt7tpF5m3E=; b=U4VU5llYab5HRHLSga3rdP+lv/YkP8th3zOg2SHdBMXwILrOnKwcGXai/FE7xcaj/OoOjO ZakgAd4YOSo8kNW422yOfCDlQTOTG722NZt/t6acrCVxZ1FACTLkR4wqnoyGbXgYH2G3OE XuAo7aox9stwIdU7fo2erppLBfrpdbs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-569-yZMWMFWCOfiUfZQrUNvBgQ-1; Tue, 23 Feb 2021 10:23:20 -0500 X-MC-Unique: yZMWMFWCOfiUfZQrUNvBgQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38504922A07; Tue, 23 Feb 2021 15:20:01 +0000 (UTC) Received: from nautilus.local (unknown [10.40.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE0655D9D3; Tue, 23 Feb 2021 15:19:55 +0000 (UTC) Date: Tue, 23 Feb 2021 16:19:53 +0100 From: Erik Skultety To: Wainer dos Santos Moschetta Subject: Re: [PATCH 0/3] gitlab-pipeline-status script: provide more information on errors Message-ID: References: <20210222193240.921250-1-crosa@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eskultet@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eskultet@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , Eduardo Habkost , Stefan Hajnoczi , Alex =?utf-8?Q?Benn=C3=A9e?= , Andrea Bolognani , qemu-devel@nongnu.org, Willian Rampazzo , Cleber Rosa , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Beraldo Leal Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Feb 23, 2021 at 11:52:17AM -0300, Wainer dos Santos Moschetta wrote: > Hi Cleber, > > In case you need to send a v2, mind to add the following patch together? > > commit 3c4ed8a78e096e4d7df0398c29887a9d468ae120 (HEAD -> gitlab_runners) > Author: Wainer dos Santos Moschetta > Date:   Tue Feb 23 11:26:08 2021 -0300 > >     scripts/ci/gitlab-pipeline-status: Handle ValueError exceptions nicely > >     With this change, when getting the local branch, it will handle nicely >     any threw ValueError exception instead of print the stack trace. > >     Signed-off-by: Wainer dos Santos Moschetta > > diff --git a/scripts/ci/gitlab-pipeline-status > b/scripts/ci/gitlab-pipeline-status > index 924db327ff..6177df973a 100755 > --- a/scripts/ci/gitlab-pipeline-status > +++ b/scripts/ci/gitlab-pipeline-status > @@ -160,7 +160,11 @@ def main(): >      args = parser.parse_args() > >      if not args.commit: > -        args.commit = get_local_branch_commit(args.branch) > +        try: > +            args.commit = get_local_branch_commit(args.branch) > +        except ValueError as error: > +            print("ERROR: %s" % error) > +            sys.exit(1) 1 is the default error code, so you should pass the error message to sys.exit directly without the print. If you don't want that, at least redirect the print to sys.stderr. Erik