From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Hao Wang <wanghao232@huawei.com>
Cc: yubihong@huawei.com, alex.chen@huawei.com, berrange@redhat.com,
zhang.zhanghailiang@huawei.com, quintela@redhat.com,
qemu-devel@nongnu.org, xiexiangyou@huawei.com,
zhengchuan@huawei.com
Subject: Re: [PATCH v2 0/2] add error handling in multifd_tls_handshake_thread
Date: Mon, 15 Mar 2021 17:20:50 +0000 [thread overview]
Message-ID: <YE+XckEzNis3EjdI@work-vm> (raw)
In-Reply-To: <20210209104237.2250941-1-wanghao232@huawei.com>
* Hao Wang (wanghao232@huawei.com) wrote:
> If any error happens during multifd send thread creating (e.g. channel broke
> because new domain is destroyed by the dst), multifd_tls_handshake_thread
> may exit silently, leaving main migration thread hanging (ram_save_setup ->
> multifd_send_sync_main -> qemu_sem_wait(&p->sem_sync)).
> Fix that by adding error handling in multifd_tls_handshake_thread.
>
> Hao Wang (2):
> migration/tls: fix inverted semantics in multifd_channel_connect
> migration/tls: add error handling in multifd_tls_handshake_thread
>
> migration/multifd.c | 21 +++++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)
Queued
>
> --
> 2.23.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2021-03-15 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 10:42 [PATCH v2 0/2] add error handling in multifd_tls_handshake_thread Hao Wang
2021-02-09 10:42 ` [PATCH v2 1/2] migration/tls: fix inverted semantics in multifd_channel_connect Hao Wang
2021-02-09 10:46 ` Daniel P. Berrangé
2021-03-06 9:08 ` Zheng Chuan
2021-02-09 10:42 ` [PATCH v2 2/2] migration/tls: add error handling in multifd_tls_handshake_thread Hao Wang
2021-02-09 10:46 ` Daniel P. Berrangé
2021-03-06 9:08 ` Zheng Chuan
2021-03-15 17:20 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YE+XckEzNis3EjdI@work-vm \
--to=dgilbert@redhat.com \
--cc=alex.chen@huawei.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=wanghao232@huawei.com \
--cc=xiexiangyou@huawei.com \
--cc=yubihong@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).