From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Daniele Buono <dbuono@linux.vnet.ibm.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v3 1/2] gitlab-ci.yml: Allow custom # of parallel linkers
Date: Thu, 4 Mar 2021 10:38:05 +0000 [thread overview]
Message-ID: <YEC4jaROHvxeL8bS@redhat.com> (raw)
In-Reply-To: <20210304030948.9367-2-dbuono@linux.vnet.ibm.com>
On Wed, Mar 03, 2021 at 10:09:47PM -0500, Daniele Buono wrote:
> Define a new variable LD_JOBS, that can be used to select
> the maximum number of linking jobs to be executed in parallel.
> If the variable is not defined, maintain the default given by
> make -j
>
> Currently, make parallelism at build time is based on the number
> of cpus available.
>
> This doesn't work well with LTO at linking, because with LTO the
> linker has to load in memory all the intermediate object files
> for optimization.
> The end result is that, if the gitlab runner happens to run two
> linking processes at the same time, the job will fail with an
> out-of-memory error,
>
> This patch leverages the ability to maintain high parallelism at
> compile time, but limit the number of linkers executed in parallel.
>
> Signed-off-by: Daniele Buono <dbuono@linux.vnet.ibm.com>
> ---
> .gitlab-ci.yml | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-03-04 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 3:09 [PATCH v3 0/2] gitlab-ci.yml: Add jobs to test CFI Daniele Buono
2021-03-04 3:09 ` [PATCH v3 1/2] gitlab-ci.yml: Allow custom # of parallel linkers Daniele Buono
2021-03-04 10:38 ` Daniel P. Berrangé [this message]
2021-03-04 3:09 ` [PATCH v3 2/2] gitlab-ci.yml: Add jobs to test CFI flags Daniele Buono
2021-03-04 10:39 ` Daniel P. Berrangé
2021-03-04 11:21 ` Thomas Huth
2021-03-04 11:58 ` Daniel P. Berrangé
2021-03-04 19:56 ` [PATCH v3 0/2] gitlab-ci.yml: Add jobs to test CFI Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEC4jaROHvxeL8bS@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=dbuono@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).