From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC409C433DB for ; Mon, 8 Mar 2021 19:15:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C59B65177 for ; Mon, 8 Mar 2021 19:15:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C59B65177 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJLLN-0006zU-31 for qemu-devel@archiver.kernel.org; Mon, 08 Mar 2021 14:15:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJKti-00032u-Cf; Mon, 08 Mar 2021 13:46:30 -0500 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:40997) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJKtg-0004nQ-9o; Mon, 08 Mar 2021 13:46:30 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 4A68C580600; Mon, 8 Mar 2021 13:46:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 08 Mar 2021 13:46:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=QnunLDI9CUe+wWcJ1LOt0WwRmln AFUicaOgPjDZeCBY=; b=m9htXV9q4WtJyGTAjKzV55D4kz9uLHl4/ghcrSKHWj4 vx3SR+N6TiKMaXs+cqadZRcSlJh3JXgeFCW9TF6rfd94IbeHxA09zhhvaPmdCyXM /cwIWxPyXkrFAUO2zrhiEynnXhYAzIvNwP4x1tLk4MCT30c6pWynxauDuhTLmFjY amTJB35VypXy+yWzkpdaGRuyfvizkUZG4fxJqZtAwSp7/uAD8suyBFFj8g3hcdbs WDvC0evmHmkuV3P+WlEIwaySzgc1bHLClMKxBmIc2xT5gAEoIVh9JOY5MatZSKW+ HcxOE5wGFMTNn+8p02/LLfAeLGzuiUhcAL5RO4T08vg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QnunLD I9CUe+wWcJ1LOt0WwRmlnAFUicaOgPjDZeCBY=; b=b/iD15jZeEzCaue1sdTWvN 1QhAf6sYj6v+MZF/ckLnmX9GPMbYNoje7zBHZE8oOq1NYWWDoFTy1ZR4xh2ddYOp 7qd09stfRzS5HOIWckebbVczKTPG4Ggjt7ToZQSG6DuPJaa6rhcy1SEChYTd25Sv w67HPjxYr/bNtfSTmivL1RU+V6+uhZ1k/y6W4kXnd1Gh2cDOG5fuIpumWmS8RKpE 7bfaG4tXlR4/l5qSn2MmYEZ93C5ebsUYoIR1KDb7yyOwiQSvW5NNY82mQBYSSXUI 8GrjPKUGpoUKLK6T7wMixA2aElGNL5ued/vDQsaWK62OI3TVo3P8YFWej9bmjBtA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddugedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeehgeehgfffgeekveefteetudekheejffdtvedvudfgffelleefvdfftdekgffg udenucffohhmrghinhepvddtudelqddtkedrohhrghenucfkphepkedtrdduieejrdelke drudeltdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id AFBFB1080054; Mon, 8 Mar 2021 13:46:23 -0500 (EST) Date: Mon, 8 Mar 2021 19:46:21 +0100 From: Klaus Jensen To: Paolo Bonzini Subject: Re: [PULL 01/38] hw/block/nvme: introduce nvme-subsys device Message-ID: References: <20210308122313.286938-1-its@irrelevant.dk> <20210308122313.286938-2-its@irrelevant.dk> <48178d72-444c-91fd-c1ef-0ae28b8a674e@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AMWcBMgIGZyrVgpg" Content-Disposition: inline In-Reply-To: <48178d72-444c-91fd-c1ef-0ae28b8a674e@redhat.com> Received-SPF: pass client-ip=66.111.4.229; envelope-from=its@irrelevant.dk; helo=new3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , qemu-block@nongnu.org, Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi , Keith Busch , Kevin Wolf Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --AMWcBMgIGZyrVgpg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mar 8 19:32, Paolo Bonzini wrote: > On 08/03/21 13:22, Klaus Jensen wrote: > >=20 > > This patch introduced a simple nvme-subsys device model. The subsystem > > will be prepared with subsystem NQN with provided in > > nvme-subsys device: > >=20 > > ex) -device nvme-subsys,id=3Dsubsys0: nqn.2019-08.org.qemu:subsys0 >=20 > Hi Klaus, sorry for not spotting this before. In the SCSI subsystem we > moved away from using id as guest-visible data. Keeping it as a default = is > fine I guess, but would it be possible to add an nqn property to nvme-sub= sys > and use it if it is present instead of the id? >=20 > Thanks, >=20 > Paolo >=20 Hi Paolo, Thanks for pointing this out! Absolutely - we have no specific reason to use 'id', so we can just change it completely to use 'nqn'. Peter, you want this in a v2 or did you already start integration of this PR? --AMWcBMgIGZyrVgpg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmBGcPwACgkQTeGvMW1P DelxTQgAtszrIjomIH1kxEAa9xrLsw8K9go4Tto/6DkPbl95aBzVCaj+QZCtwZAU x4rdJPOa203grb/Rwngw9yHkyiXUHCwTu9q5ItDLbVuixVIma/SeU7tyE9sH5owk VYDNtnsjI861M6C0+JwgQlPIYYdAGAo9fuJGJKM9nO5PqAxNLgMztxazmc2EjPOs RMe4R9FUxB1VESAxt2gk8CugA1eANzv286MFqhgMa973lbLS6p76opGAp6G5MSQh C/lqWJaqHkgTtYgEPRKrOfIovDXGxMbAA/AxlMlMycT6JdaLDG+Iy0lL0GxAnAK8 VJlRL9AUYJoY0I4cug+u6de6ir/rSw== =pfUV -----END PGP SIGNATURE----- --AMWcBMgIGZyrVgpg--