From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E53C2C433E0 for ; Tue, 9 Mar 2021 13:34:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45E9F64F69 for ; Tue, 9 Mar 2021 13:34:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45E9F64F69 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJcV6-0001ql-A3 for qemu-devel@archiver.kernel.org; Tue, 09 Mar 2021 08:34:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJcJ9-0005T6-Uq for qemu-devel@nongnu.org; Tue, 09 Mar 2021 08:21:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31289) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lJcJ5-0000bh-Ks for qemu-devel@nongnu.org; Tue, 09 Mar 2021 08:21:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615296110; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=fIfhDhvvVg9Nn67ijxh8hQY9TPf7K9ctxDitP4qM8Ao=; b=Nr0Znl71CDZ3iAsJaPmiyj+nxHgohHVsXjfyueEKW/EJHqQrrPFw1IxfgAy4VmIyik1Lho /vPhzuZXH+EhkepNPttzRrNYiU/qH+sA/VdJN17NoaR9Tgp8n/V6Tz9MVwYg71X0TzCt4i GA/5jz+GSOxbdIqLcpf4JCxa/D4cif8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-f904s_HyOgmvHePQM3uWaQ-1; Tue, 09 Mar 2021 08:21:36 -0500 X-MC-Unique: f904s_HyOgmvHePQM3uWaQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7FC17B9B; Tue, 9 Mar 2021 13:21:34 +0000 (UTC) Received: from redhat.com (ovpn-114-154.ams2.redhat.com [10.36.114.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4CB0C5D9DB; Tue, 9 Mar 2021 13:21:17 +0000 (UTC) Date: Tue, 9 Mar 2021 13:21:14 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Gerd Hoffmann Subject: Re: [PATCH v3 1/1] hw/s390x: modularize virtio-gpu-ccw Message-ID: References: <20210302173544.3704179-1-pasic@linux.ibm.com> <20210305214603.GF3139005@habkost.net> <20210309124512.6goag5jblcje3umk@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: <20210309124512.6goag5jblcje3umk@sirius.home.kraxel.org> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Thomas Huth , Boris Fiuczynski , Eduardo Habkost , David Hildenbrand , Cornelia Huck , Richard Henderson , qemu-devel@nongnu.org, Bruce Rogers , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, "Michael S. Tsirkin" , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Mar 09, 2021 at 01:45:12PM +0100, Gerd Hoffmann wrote: > On Fri, Mar 05, 2021 at 04:46:03PM -0500, Eduardo Habkost wrote: > > On Tue, Mar 02, 2021 at 06:35:44PM +0100, Halil Pasic wrote: > > > Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu > > > module, which provides the type virtio-gpu-device, packaging the > > > hw-display-virtio-gpu module as a separate package that may or may not > > > be installed along with the qemu package leads to problems. Namely if > > > the hw-display-virtio-gpu is absent, qemu continues to advertise > > > virtio-gpu-ccw, but it aborts not only when one attempts using > > > virtio-gpu-ccw, but also when libvirtd's capability probing tries > > > to instantiate the type to introspect it. > > > > > > Let us thus introduce a module named hw-s390x-virtio-gpu-ccw that > > > is going to provide the virtio-gpu-ccw device. The hw-s390x prefix > > > was chosen because it is not a portable device. Because registering > > > virtio-gpu-ccw would make non-s390x emulator fail due to a missing > > > parent type, if built as a module, before registering it, we check > > > if the ancestor types are already registered. > > > > I don't understand what makes it necessary to make the > > type_register() call conditional. Calling type_register() before > > the parent types are registered is perfectly valid. > > Well, yes, in a non-modular world this will work perfectly fine. We > only compile objects actually supported into the system emulator. > > With modular builds we have the situation that we have shared modules > which may or may not work in specific system emulators, for example > hw-display-virtio-gpu-pci.so or the ccw module added by this patch, > because the given system emulator doesn't provide the needed support. > We have some which don't support pci (avr for example). Likewise ccw > is supported by s390x only. We could solve this by having a different location for loading modules for each target. * /usr/$LIB/qemu/ All the real .so's go in here as today * /usr/$LIB/qemu/$TARGET Populated with symlinks to the .so's in the parent dir, but /only/ those which are valid for this $TARGET Then change QEMU to load from the second dir. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|