From: David Gibson <david@gibson.dropbear.id.au>
To: Ivan Warren <ivan@vmfacility.fr>
Cc: peter.maydell@linaro.org, richard.henderson@linaro.org,
qemu-ppc@nongnu.org, groug@kaod.org, qemu-devel@nongnu.org
Subject: Re: [PULL 00/20] ppc-for-6.0 queue 20210310
Date: Thu, 11 Mar 2021 15:56:47 +1100 [thread overview]
Message-ID: <YEmjDwpfYwLOaVe/@yekko.fritz.box> (raw)
In-Reply-To: <e6bee42f-661b-a5a6-bb45-0b93167fb227@vmfacility.fr>
[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]
On Thu, Mar 11, 2021 at 04:22:44AM +0100, Ivan Warren wrote:
>
> On 3/11/2021 2:47 AM, David Gibson wrote:
> >
> > Sorry, I've forgotten this issue. If you had a patch, can you resend
> > it please.
>
> Not mine.. (I reported it, but can't remember who sent it)...
>
> diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
>
> index 2609e4082e..4a05e4e544 100644
> --- a/target/ppc/cpu.h
> +++ b/target/ppc/cpu.h
> @@ -2396,8 +2396,8 @@ static inline void cpu_get_tb_cpu_state(CPUPPCState
> *env, target_ulong *pc,
> target_ulong *cs_base, uint32_t
> *flags)
> {
> *pc = env->nip;
> - *cs_base = 0;
> - *flags = env->hflags;
> + *cs_base = env->hflags;
> + *flags = 0;
> }
Ah, that one. It caused a regression, so I dropped it. I pinged
Richard Henderson about it, but I don't think I even had a reply.
I'm afraid I don't have the knowledge or the time to debug this
myself.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-03-11 11:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 4:09 [PULL 00/20] ppc-for-6.0 queue 20210310 David Gibson
2021-03-10 4:09 ` [PULL 01/20] hw/display/sm501: Remove dead code for non-32-bit RGB surfaces David Gibson
2021-03-10 4:09 ` [PULL 02/20] hw/display/sm501: Expand out macros in template header David Gibson
2021-03-10 4:09 ` [PULL 03/20] hw/display/sm501: Inline template header into C file David Gibson
2021-03-10 4:09 ` [PULL 04/20] spapr_drc.c: do not call spapr_drc_detach() in drc_isolate_logical() David Gibson
2021-03-10 4:09 ` [PULL 05/20] pseries: Update SLOF firmware image David Gibson
2021-03-10 4:09 ` [PULL 06/20] spapr_drc.c: use spapr_drc_release() in isolate_physical/set_unusable David Gibson
2021-03-10 4:09 ` [PULL 07/20] spapr: rename spapr_drc_detach() to spapr_drc_unplug_request() David Gibson
2021-03-10 4:09 ` [PULL 08/20] docs/system: Extend PPC section David Gibson
2021-03-10 4:09 ` [PULL 09/20] target/ppc: Fix bcdsub. emulation when result overflows David Gibson
2021-03-10 4:09 ` [PULL 10/20] spapr_drc.c: introduce unplug_timeout_timer David Gibson
2021-03-10 4:09 ` [PULL 11/20] spapr_drc.c: add hotunplug timeout for CPUs David Gibson
2021-03-10 4:09 ` [PULL 12/20] spapr_drc.c: use DRC reconfiguration to cleanup DIMM unplug state David Gibson
2021-03-10 4:09 ` [PULL 13/20] hw/net: fsl_etsec: Fix build error when HEX_DUMP is on David Gibson
2021-03-10 4:09 ` [PULL 14/20] hw/ppc: e500: Add missing <ranges> in the eTSEC node David Gibson
2021-03-10 4:09 ` [PULL 15/20] spapr.c: add 'unplug already in progress' message for PHB unplug David Gibson
2021-03-10 4:09 ` [PULL 16/20] spapr_pci.c: add 'unplug already in progress' message for PCI unplug David Gibson
2021-03-10 4:09 ` [PULL 17/20] qemu_timer.c: add timer_deadline_ms() helper David Gibson
2021-03-10 4:10 ` [PULL 18/20] target/ppc: fix icount support on Book-e vms accessing SPRs David Gibson
2021-03-10 4:10 ` [PULL 19/20] spapr.c: remove duplicated assert in spapr_memory_unplug_request() David Gibson
2021-03-10 4:10 ` [PULL 20/20] spapr.c: send QAPI event when memory hotunplug fails David Gibson
2021-03-10 4:43 ` [PULL 00/20] ppc-for-6.0 queue 20210310 Bin Meng
2021-03-10 6:00 ` David Gibson
2021-03-11 1:26 ` Bin Meng
2021-03-10 14:09 ` Ivan Warren
2021-03-11 1:47 ` David Gibson
2021-03-11 3:22 ` Ivan Warren
2021-03-11 4:56 ` David Gibson [this message]
2021-03-11 13:31 ` Richard Henderson
2021-03-11 15:54 ` Greg Kurz
2021-03-11 18:02 ` Greg Kurz
2021-03-12 13:53 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEmjDwpfYwLOaVe/@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=ivan@vmfacility.fr \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).