From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, libvir-list@redhat.com,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
mreitz@redhat.com, jsnow@redhat.com
Subject: Re: [PATCH v4 4/4] blockdev: Drop deprecated bogus -drive interface type
Date: Thu, 11 Mar 2021 09:44:57 +0000 [thread overview]
Message-ID: <YEnmmT35/MYBI1qQ@redhat.com> (raw)
In-Reply-To: <20210311075221.1795266-5-armbru@redhat.com>
On Thu, Mar 11, 2021 at 08:52:21AM +0100, Markus Armbruster wrote:
> Drop the crap deprecated in commit a1b40bda08 "blockdev: Deprecate
> -drive with bogus interface type" (v5.1.0).
>
> drive_check_orphaned() no longer depends on qemu_create_cli_devices().
> Call it right after board initialization for clarity.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> docs/system/deprecated.rst | 7 ------
> docs/system/removed-features.rst | 7 ++++++
> include/sysemu/blockdev.h | 1 -
> blockdev.c | 37 +++++++++++++-------------------
> softmmu/vl.c | 11 +---------
> 5 files changed, 23 insertions(+), 40 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-03-11 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 7:52 [PATCH v4 0/4] Drop deprecated floppy config & bogus -drive if=T Markus Armbruster
2021-03-11 7:52 ` [PATCH v4 1/4] docs/system/deprecated: Fix note on fdc drive properties Markus Armbruster
2021-03-11 7:52 ` [PATCH v4 2/4] fdc: Drop deprecated floppy configuration Markus Armbruster
2021-03-11 7:52 ` [PATCH v4 3/4] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common() Markus Armbruster
2021-03-11 7:52 ` [PATCH v4 4/4] blockdev: Drop deprecated bogus -drive interface type Markus Armbruster
2021-03-11 9:44 ` Daniel P. Berrangé [this message]
2021-03-12 1:17 ` [PATCH v4 0/4] Drop deprecated floppy config & bogus -drive if=T John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEnmmT35/MYBI1qQ@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).