From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20CBAC433E0 for ; Thu, 11 Mar 2021 18:31:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90FD364FD6 for ; Thu, 11 Mar 2021 18:31:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90FD364FD6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKQ5v-0002J7-7h for qemu-devel@archiver.kernel.org; Thu, 11 Mar 2021 13:31:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKQ3e-0000nC-T9 for qemu-devel@nongnu.org; Thu, 11 Mar 2021 13:29:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lKQ3a-0003un-2g for qemu-devel@nongnu.org; Thu, 11 Mar 2021 13:29:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615487348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Krq+JyQNtwrTnECSYNvI/8vGLITw7wKdKrxzYHJUZMs=; b=QSWMSR72okaeC3PAYTA9GiEihNgSVhM5lLEmM3Ml87VoVRWlbZY3JgTGtCxmKSGzfoX6lS 3DDLGcrUbmcXkSQ4wNcVbZaA9hVCVR/T/8Ose2bnopgt3yiEqwtKsuFQdBh+c1dH7zGXse L/aJGl2Ji8lXNflmBmUNkE4LQq49sZs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-Pi_Z-hGuPLOsjcSm1ZE8UQ-1; Thu, 11 Mar 2021 13:29:04 -0500 X-MC-Unique: Pi_Z-hGuPLOsjcSm1ZE8UQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5BAF51923761; Thu, 11 Mar 2021 18:29:03 +0000 (UTC) Received: from work-vm (ovpn-115-29.ams2.redhat.com [10.36.115.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A63295C1C5; Thu, 11 Mar 2021 18:29:00 +0000 (UTC) Date: Thu, 11 Mar 2021 18:28:57 +0000 From: "Dr. David Alan Gilbert" To: Laurent Vivier Subject: Re: [PATCH] migration: Remove time_t cast for OpenBSD Message-ID: References: <7eaad721-9d2a-83ed-00fc-80c8ee37e156@redhat.com> <26c9c34a-3872-c044-4b01-06d2eb4bfbb1@vivier.eu> MIME-Version: 1.0 In-Reply-To: <26c9c34a-3872-c044-4b01-06d2eb4bfbb1@vivier.eu> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Thomas Huth , Juan Quintela , qemu-devel@nongnu.org, Brad Smith Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Laurent Vivier (laurent@vivier.eu) wrote: > Le 08/03/2021 à 12:46, Thomas Huth a écrit : > > On 22/02/2021 08.28, Brad Smith wrote: > >> OpenBSD has supported 64-bit time_t across all archs since 5.5 released in 2014. > >> > >> Remove a time_t cast that is no longer necessary. > >> > >> > >> Signed-off-by: Brad Smith > >> > >> diff --git a/migration/savevm.c b/migration/savevm.c > >> index 52e2d72e4b..9557f85ba9 100644 > >> --- a/migration/savevm.c > >> +++ b/migration/savevm.c > >> @@ -2849,8 +2849,7 @@ bool save_snapshot(const char *name, bool overwrite, const char *vmstate, > >>       if (name) { > >>           pstrcpy(sn->name, sizeof(sn->name), name); > >>       } else { > >> -        /* cast below needed for OpenBSD where tv_sec is still 'long' */ > >> -        localtime_r((const time_t *)&tv.tv_sec, &tm); > >> +        localtime_r(&tv.tv_sec, &tm); > >>           strftime(sn->name, sizeof(sn->name), "vm-%Y%m%d%H%M%S", &tm); > >>       } > > > > but the qemu_timeval from "include/sysemu/os-win32.h" still uses a long: is this file compiled for > win32? Yep this fails for me when built with x86_64-w64-mingw32- (it's fine with i686-w64-mingw32- ) Dave > Thanks, > Laurent > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK