From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC35C433DB for ; Tue, 16 Mar 2021 14:57:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1C996508A for ; Tue, 16 Mar 2021 14:57:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1C996508A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMB8A-0003uK-Hx for qemu-devel@archiver.kernel.org; Tue, 16 Mar 2021 10:57:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMB7I-0003KN-Qu for qemu-devel@nongnu.org; Tue, 16 Mar 2021 10:56:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMB7G-0004g2-59 for qemu-devel@nongnu.org; Tue, 16 Mar 2021 10:56:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615906572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mgqgFWkIGF8tPWXbcf//kFMgzZm9lVpPpYCuAS8h5nY=; b=Ryn7GkDZOpFXIhnVaTICTQ9YDDONk+fJeid7bfNoAzudrgq+4kiy7Fz2g6LEMF8kZ1SDfg WgAFzTuOxEBJdkkTm1gEtz/N04asamPxPNCgtwiZ1rPxzL53KRsc/S9xbYHhOvfXdXxJ8o iYlCCnKnMAaw26gSU+IEFrPnBcLo6rY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-99-YcwniRNKP6iOZnqdr6ZC8g-1; Tue, 16 Mar 2021 10:56:10 -0400 X-MC-Unique: YcwniRNKP6iOZnqdr6ZC8g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 755D6107ACCA; Tue, 16 Mar 2021 14:56:09 +0000 (UTC) Received: from merkur.fritz.box (ovpn-112-216.ams2.redhat.com [10.36.112.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0079D60C13; Tue, 16 Mar 2021 14:56:00 +0000 (UTC) Date: Tue, 16 Mar 2021 15:55:59 +0100 From: Kevin Wolf To: Peter Maydell Subject: Re: [PULL v2 00/42] Block layer patches and object-add QAPIfication Message-ID: References: <20210315123520.118752-1-kwolf@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qemu-block , QEMU Developers , stefanha@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 16.03.2021 um 15:35 hat Kevin Wolf geschrieben: > Am 16.03.2021 um 14:17 hat Peter Maydell geschrieben: > > On Mon, 15 Mar 2021 at 12:35, Kevin Wolf wrote: > > > > > > The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14: > > > > > > Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-request' into staging (2021-03-14 17:47:49 +0000) > > > > > > are available in the Git repository at: > > > > > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > > > > > for you to fetch changes up to 078ee48ef7d172df1b3ad020255d1eb6beda2daf: > > > > > > qom: Support JSON in HMP object_add and tools --object (2021-03-15 13:04:27 +0100) > > > > > > ---------------------------------------------------------------- > > > Block layer patches and object-add QAPIfication > > > > > > - QAPIfy object-add and --object for tools (keyval and JSON support) > > > - Add vhost-user-blk-test > > > - stream: Fail gracefully if permission is denied > > > - storage-daemon: Fix crash on quit when job is still running > > > - curl: Fix use after free > > > - char: Deprecate backend aliases, fix QMP query-chardev-backends > > > - Fix image creation option defaults that exist in both the format and > > > the protocol layer (e.g. 'cluster_size' in qcow2 and rbd; the qcow2 > > > default was incorrectly applied to the rbd layer) > > > > > > ---------------------------------------------------------------- > > > > Fails 'make check' on x86-64 linux: > > > > PASS 61 qtest-x86_64/qos-test > > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-blk-pci/virtio-blk/virtio-blk-tests/config > > PASS 62 qtest-x86_64/qos-test > > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-blk-pci/virtio-blk/virtio-blk-tests/basic > > PASS 63 qtest-x86_64/qos-test > > /x86_64/pc/i440FX-pcihost/pci-bus-pc/pci-bus/virtio-blk-pci/virtio-blk/virtio-blk-tests/resize > > ** > > ERROR:../../tests/qtest/libqos/virtio.c:194:qvirtio_wait_status_byte_no_isr: > > assertion failed: (!d->bus->get_queue_isr_status(d, vq)) > > ERROR qtest-x86_64/qos-test - Bail out! > > ERROR:../../tests/qtest/libqos/virtio.c:194:qvirtio_wait_status_byte_no_isr: > > assertion failed: (!d->bus->get_queue_isr_status(d, vq)) > > Makefile.mtest:1008: recipe for target 'run-test-124' failed > > make: *** [run-test-124] Error 1 > > It didn't fail to me, so the condition must be a little more specific > than just x86_64 Linux. > > Stefan, can you have a look? I may have to drop these patches again. Actually, these are not the new vhost-user-blk test, but just the normal virtio-blk ones and it's probably unrelated. This is weird, because this pull request doesn't include any change to virtio-blk or the related qtests. Could this be intermittent failure of a change introduced by an earlier pull request? Peter, which environment was this and are full logs available? It doesn't seem to be the Gitlab CI (because the build is still running there and hasn't failed yet). My first attempts to reproduce have failed so far. Kevin