From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D8E9C433E0 for ; Tue, 16 Mar 2021 16:48:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4EF8650B1 for ; Tue, 16 Mar 2021 16:48:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4EF8650B1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=NetBSD.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMCrl-0000oK-2n for qemu-devel@archiver.kernel.org; Tue, 16 Mar 2021 12:48:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMCkn-0006cq-WF for qemu-devel@nongnu.org; Tue, 16 Mar 2021 12:41:10 -0400 Received: from 13thmonkey.org ([80.100.255.32]:58575 helo=diablo.13thmonkey.org) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMCkm-0002m3-6K for qemu-devel@nongnu.org; Tue, 16 Mar 2021 12:41:09 -0400 Received: by diablo.13thmonkey.org (Postfix, from userid 103) id 49A3EC13ADD; Tue, 16 Mar 2021 17:41:04 +0100 (CET) Date: Tue, 16 Mar 2021 17:41:04 +0100 From: Reinoud Zandijk To: Isaku Yamahata Subject: Re: Windows 10 won't run on default x86_64 machine anymore Message-ID: References: <20210315185302.29b0d90d@redhat.com> <20210316015503.GA1008366@private.email.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316015503.GA1008366@private.email.ne.jp> Received-SPF: none client-ip=80.100.255.32; envelope-from=reinoud@diablo.13thmonkey.org; helo=diablo.13thmonkey.org X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Mar 15, 2021 at 06:55:03PM -0700, Isaku Yamahata wrote: > I think tcg case can be explained by x86_machine_is_smm_enabled() > > bool x86_machine_is_smm_enabled(const X86MachineState *x86ms) > ... > if (tcg_enabled() || qtest_enabled()) { > smm_available = true; > } else if (kvm_enabled()) { > smm_available = kvm_has_smm(); > } > ... > > Although I don't know about nvmm case, this function also needs to be updated > if smi isn't supported. I can create a local patch to enable SMM here when NVMM is enabled if KVM, HAX and HWPX work fine. Shouldn't this check be rewritten? What about HWPX and the others? They will always report smm_available=false here. Reinoud