From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: mrolnik@gmail.com
Cc: philmd@redhat.com, qemu-devel@nongnu.org
Subject: of AVR target page size
Date: Wed, 17 Mar 2021 20:14:26 +0000 [thread overview]
Message-ID: <YFJjIq45ggSZz0CX@work-vm> (raw)
Hi Michael,
I noticed your AVR code defines:
#define TARGET_PAGE_BITS 8
and has an explanation of why.
Note however that's not going to work with the current live
migration/snapshotting code, since you're a couple of bits smaller
than the smallest page size we had so far, and for many years
the RAM migration code has stolen the bottom few bits of the address
as a flag field, and has already used 0x100 up; see migration/ram.c
RAM_SAVE_FLAG_* - and it's actually tricky to change it, because if
you change it then it'll break migration compatibility with existing
qemu's.
Hmm.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next reply other threads:[~2021-03-17 20:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 20:14 Dr. David Alan Gilbert [this message]
2021-03-17 21:32 ` of AVR target page size Michael Rolnik
2021-03-18 9:55 ` Dr. David Alan Gilbert
2021-03-18 10:15 ` Michael Rolnik
2021-03-18 10:21 ` Dr. David Alan Gilbert
2021-03-17 22:33 ` Peter Maydell
2021-03-18 7:37 ` Michael Rolnik
2021-03-18 10:18 ` Dr. David Alan Gilbert
2021-03-18 10:21 ` Peter Maydell
2021-03-18 10:25 ` Dr. David Alan Gilbert
2021-03-18 10:34 ` Peter Maydell
2021-03-18 10:45 ` Dr. David Alan Gilbert
2021-03-18 11:03 ` Michael Rolnik
2021-03-18 20:03 ` Dr. David Alan Gilbert
2021-03-18 11:12 ` Peter Maydell
2021-03-18 20:05 ` Dr. David Alan Gilbert
2021-03-18 20:14 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFJjIq45ggSZz0CX@work-vm \
--to=dgilbert@redhat.com \
--cc=mrolnik@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).