* Is accel/stubs/ still needed? (resent)
@ 2021-03-20 14:15 Reinoud Zandijk
2021-03-22 10:07 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Reinoud Zandijk @ 2021-03-20 14:15 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
Hi,
a quick question. I forgot to add my accel/stubs/nvmm-stub.h to
accel/stubs/meson.build but even when I disable NVMM explicitly or build it on
a NetBSD platform that does not support NVMM, it just compiled. So, is it
actually still used?
With regards,
Reinoud
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Is accel/stubs/ still needed? (resent)
2021-03-20 14:15 Is accel/stubs/ still needed? (resent) Reinoud Zandijk
@ 2021-03-22 10:07 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-22 10:07 UTC (permalink / raw)
To: Reinoud Zandijk, qemu-devel
On 3/20/21 3:15 PM, Reinoud Zandijk wrote:
> Hi,
>
> a quick question. I forgot to add my accel/stubs/nvmm-stub.h
Stub ending in .h? Suspicious... Rename it .c?
> to
> accel/stubs/meson.build but even when I disable NVMM explicitly or build it on
> a NetBSD platform that does not support NVMM, it just compiled. So, is it
> actually still used?
Stub is usually required when you have to call specific code from
generic one. If your specific code is NVMM, then you should test
QEMU still builds outside of NetBSD / NVMM, where the NVMM stubs
would be used.
Regards,
Phil.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-22 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-20 14:15 Is accel/stubs/ still needed? (resent) Reinoud Zandijk
2021-03-22 10:07 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).