From: David Gibson <david@gibson.dropbear.id.au>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Jason Wang <jasowang@redhat.com>,
qemu-ppc@nongnu.org, Greg Kurz <groug@kaod.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC
Date: Mon, 22 Mar 2021 14:22:12 +1100 [thread overview]
Message-ID: <YFgNZFAKjVhder2R@yekko.fritz.box> (raw)
In-Reply-To: <20210316081505.72898-1-bmeng.cn@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]
On Tue, Mar 16, 2021 at 04:15:05PM +0800, Bin Meng wrote:
> As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU",
> min_frame_len should excluce CRC, so it should be 60 instead of 64.
Sorry, your reasoning still isn't clear to me. If qemu is not adding
the CRC, what is? Will it always append a CRC after this padding is
complete?
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> hw/net/fsl_etsec/rings.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
> index d6be0d7d18..8f08446415 100644
> --- a/hw/net/fsl_etsec/rings.c
> +++ b/hw/net/fsl_etsec/rings.c
> @@ -259,7 +259,7 @@ static void process_tx_bd(eTSEC *etsec,
> || etsec->regs[MACCFG2].value & MACCFG2_PADCRC) {
>
> /* Padding and CRC (Padding implies CRC) */
> - tx_padding_and_crc(etsec, 64);
> + tx_padding_and_crc(etsec, 60);
>
> } else if (etsec->first_bd.flags & BD_TX_TC
> || etsec->regs[MACCFG2].value & MACCFG2_CRC_EN) {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-03-22 4:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 8:15 [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC Bin Meng
2021-03-22 1:29 ` Bin Meng
2021-03-22 3:22 ` David Gibson
2021-03-22 3:22 ` David Gibson [this message]
2021-03-22 4:33 ` Bin Meng
2021-03-22 5:17 ` David Gibson
2021-03-22 5:48 ` Bin Meng
2021-03-23 0:08 ` David Gibson
2021-03-23 0:08 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFgNZFAKjVhder2R@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=bmeng.cn@gmail.com \
--cc=groug@kaod.org \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).