From: Kevin Wolf <kwolf@redhat.com>
To: "Patrik Janoušek" <pj@patrikjanousek.cz>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, lmatejka@kiv.zcu.cz
Subject: Re: [PATCH 0/2] block/raw: implemented persistent dirty bitmap and ability to dump bitmap content via qapi
Date: Mon, 22 Mar 2021 15:53:22 +0100 [thread overview]
Message-ID: <YFivYmPMRyqbM4zf@merkur.fritz.box> (raw)
In-Reply-To: <a87aadc1-d795-27cd-35c7-a5c4175df687@patrikjanousek.cz>
Hi Patrik,
Am 22.03.2021 um 09:57 hat Patrik Janoušek geschrieben:
> On 3/22/21 9:29 AM, Vladimir Sementsov-Ogievskiy wrote:
> > We do have external incremental backups, based on Qemu bitmap API. But
> > it depends of course on qcow2 persistent bitmaps feature.
>
> Yes, I know. And that's the problem. The point of my bachelor thesis is
> to implement a backup solution for the raw format.
the problem with this is that raw isn't really a format, it's more the
absence of a format. You just have the content of the virtual disk in a
file and that's it. This means not having any metadata (apart from the
metadata stored in the filesystem, of course).
As soon as you add metadata in some way (in your case, by referencing
additional metadata files in runtime options), it's not raw any more. If
you write to the raw image file without updating the metadata, the
metadata becomes inconsistent with the content. In other words, both
files form a single disk image together and can only be used together or
you're breaking them.
This in turn means that you have just invented a new image format. It's
a bit unconventional in that it's spread across multiple files, and that
some of the metadata that brings everything together is even in command
line options instead of a file, but you have to combine these components
in the same way every time you start the VM, so it really is a new image
format.
We have gone through such discussions a while ago because obviously "raw
with dirty bitmaps" was a request that came soon after we discussed
persistent dirty maps. But as we came to the conclusion that any
addition to raw would create another new image format specific to QEMU,
we decided that we can as well use qcow2 for this, which is already the
fully featured QEMU image format.
I hope this background helps a bit to explain the reactions you have
received so far.
Kevin
next prev parent reply other threads:[~2021-03-22 15:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 9:32 [PATCH 0/2] block/raw: implemented persistent dirty bitmap and ability to dump bitmap content via qapi Patrik Janoušek
2021-03-20 9:32 ` [PATCH 1/2] block/raw: added support of persistent dirty bitmaps Patrik Janoušek
2021-03-22 8:41 ` Vladimir Sementsov-Ogievskiy
2021-03-22 10:18 ` Patrik Janoušek
2021-03-22 10:46 ` Vladimir Sementsov-Ogievskiy
2021-03-22 11:18 ` Vladimir Sementsov-Ogievskiy
2021-03-22 11:36 ` Patrik Janoušek
2021-03-22 20:27 ` Lubos Matejka
2021-03-22 15:43 ` Kevin Wolf
2021-03-20 9:32 ` [PATCH 2/2] qapi: implementation of the block-dirty-bitmap-dump command Patrik Janoušek
2021-03-22 9:02 ` Vladimir Sementsov-Ogievskiy
2021-03-22 15:12 ` Kevin Wolf
2021-03-22 8:29 ` [PATCH 0/2] block/raw: implemented persistent dirty bitmap and ability to dump bitmap content via qapi Vladimir Sementsov-Ogievskiy
2021-03-22 8:57 ` Patrik Janoušek
2021-03-22 14:53 ` Kevin Wolf [this message]
[not found] ` <856ca6ba-3871-068f-f821-269c40a5a4d5@patrikjanousek.cz>
2021-03-22 10:48 ` Fwd: " Max Reitz
2021-03-22 11:27 ` Patrik Janoušek
2021-03-22 12:06 ` Max Reitz
2021-03-22 21:45 ` Patrik Janoušek
2021-03-22 12:44 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFivYmPMRyqbM4zf@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=lmatejka@kiv.zcu.cz \
--cc=pj@patrikjanousek.cz \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).