From: David Gibson <david@gibson.dropbear.id.au>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Ivan Warren <ivan@vmfacility.fr>,
qemu-ppc@nongnu.org, Greg Kurz <groug@kaod.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR
Date: Tue, 30 Mar 2021 15:54:36 +1100 [thread overview]
Message-ID: <YGKvDOCtfbj0avYF@yekko.fritz.box> (raw)
In-Reply-To: <d0221e19-6c8b-6cc3-c4aa-2d5fff4ecb8b@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2904 bytes --]
On Mon, Mar 29, 2021 at 10:26:02AM -0600, Richard Henderson wrote:
> On 3/29/21 7:05 AM, Greg Kurz wrote:
> > On Wed, 24 Mar 2021 11:03:02 +1100
> > David Gibson <david@gibson.dropbear.id.au> wrote:
> >
> > > On Tue, Mar 23, 2021 at 12:43:32PM -0600, Richard Henderson wrote:
> > > > Copying flags directly from msr has drawbacks: (1) msr bits
> > > > mean different things per cpu, (2) msr has 64 bits on 64 cpus
> > > > while tb->flags has only 32 bits.
> > > >
> > > > Create a enum to define these bits. Document the origin of each bit
> > > > and validate those bits that must match MSR. This fixes the
> > > > truncation of env->hflags to tb->flags, because we no longer
> > > > have hflags bits set above bit 31.
> > > >
> > > > Most of the code in ppc_tr_init_disas_context is moved over to
> > > > hreg_compute_hflags. Some of it is simple extractions from msr,
> > > > some requires examining other cpu flags. Anything that is moved
> > > > becomes a simple extract from hflags in ppc_tr_init_disas_context.
> > > >
> > > > Several existing bugs are left in ppc_tr_init_disas_context, where
> > > > additional changes are required -- to be addressed in future patches.
> > > >
> > > > Remove a broken #if 0 block.
> > > >
> > > > Reported-by: Ivan Warren <ivan@vmfacility.fr>
> > > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > >
> > > Applied to ppc-for-6.0.
> > >
> >
> > FYI I can consistently reproduce locally on my laptop an error I'm also
> > seeing in CI.
> >
> > $ ./configure --target-list=ppc64abi32-linux-user && make -j all && make check-tcg
> > ...
> > TEST threadcount on ppc64abi32
> > qemu: uncaught target signal 11 (Segmentation fault) - core dumped
> >
> > Bisect led to this commit in ppc-for-6.0
>
> Any more details? Because this works for me.
Yeah, I haven't gotten this to fail locally either.
But wait... it gets even weirder. With gitlab, I can get similar
looking failures with
A) Just the non-hflags patches from my tree
https://gitlab.com/dgibson/qemu/-/pipelines/278542370
B) Just the hflags patches from my / Richard's tree
https://gitlab.com/dgibson/qemu/-/pipelines/278497244
But I haven't managed to get the same failures with (C) their common
ancestor (i.e. the upstream master at the time I split made the (A)
and (B) branches).
https://gitlab.com/dgibson/qemu/-/pipelines/278497233
With (A) and (B) the build-user and build-user-static tests don't
always fail, but they generally seem to fail within 2-4 attempts.
I've made a bunch of retries on (C) and haven't managed to get either
build-user or build-user-static to fail.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-03-30 5:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 18:43 [PATCH v5 00/10] target/ppc: Fix truncation of env->hflags Richard Henderson
2021-03-23 18:43 ` [PATCH v5 01/10] target/ppc: Extract post_load_update_msr Richard Henderson
2021-03-24 0:00 ` David Gibson
2021-03-23 18:43 ` [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR Richard Henderson
2021-03-24 0:03 ` David Gibson
2021-03-29 13:05 ` Greg Kurz
2021-03-29 16:26 ` Richard Henderson
2021-03-30 4:54 ` David Gibson [this message]
2021-03-30 15:01 ` Richard Henderson
2021-03-31 0:09 ` David Gibson
2021-03-31 4:04 ` Greg Kurz
2021-03-31 4:47 ` David Gibson
2021-03-31 6:31 ` Richard Henderson
2021-04-01 3:17 ` David Gibson
2021-03-31 7:30 ` Greg Kurz
2021-03-23 18:43 ` [PATCH v5 03/10] target/ppc: Reduce env->hflags to uint32_t Richard Henderson
2021-03-24 0:03 ` David Gibson
2021-03-23 18:43 ` [PATCH v5 04/10] target/ppc: Put dbcr0 single-step bits into hflags Richard Henderson
2021-03-24 0:04 ` David Gibson
2021-03-23 18:43 ` [PATCH v5 05/10] target/ppc: Create helper_scv Richard Henderson
2021-03-24 0:05 ` David Gibson
2021-03-23 18:43 ` [PATCH v5 06/10] target/ppc: Put LPCR[GTSE] in hflags Richard Henderson
2021-03-24 0:06 ` David Gibson
2021-03-23 18:43 ` [PATCH v5 07/10] target/ppc: Remove MSR_SA and MSR_AP from hflags Richard Henderson
2021-03-24 0:08 ` David Gibson
2021-03-23 18:43 ` [PATCH v5 08/10] target/ppc: Remove env->immu_idx and env->dmmu_idx Richard Henderson
2021-03-24 0:09 ` David Gibson
2021-03-23 18:43 ` [PATCH v5 09/10] linux-user/ppc: Fix msr updates for signal handling Richard Henderson
2021-03-24 0:10 ` David Gibson
2021-03-23 18:43 ` [PATCH v5 10/10] target/ppc: Validate hflags with CONFIG_DEBUG_TCG Richard Henderson
2021-03-24 0:12 ` David Gibson
2021-03-25 8:47 ` David Gibson
2021-03-26 12:41 ` Richard Henderson
2021-03-27 12:46 ` Richard Henderson
2021-03-28 13:09 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGKvDOCtfbj0avYF@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=ivan@vmfacility.fr \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).