From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9845AC433DB for ; Tue, 30 Mar 2021 13:11:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 362A1619BB for ; Tue, 30 Mar 2021 13:11:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 362A1619BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRE97-0000CD-Cy for qemu-devel@archiver.kernel.org; Tue, 30 Mar 2021 09:11:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRE88-00080j-Nq for qemu-devel@nongnu.org; Tue, 30 Mar 2021 09:10:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRE85-00034d-TT for qemu-devel@nongnu.org; Tue, 30 Mar 2021 09:10:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617109797; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=dpkrFDmPXjSQsf7vE3PU/iJ1d5yMhD8/Rc/MSfuIt7c=; b=GjksDlNrcLDc63K1wsGo6jYkaJr12O0szqba03IkSDStlhlAe7PAzrjhwjBhrAv/8IC0bl BQ+Avmj5ZD3PM/3iHcDaFFe15ROdH1Pqdq+q9q5qDCqVQjV0ZuSawzTn6I3jByCTFt6NLC HdPDAtTXyiqj/D+Sf3t3TlZIKIz0m30= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-298-x0-gZPDtNJmnr3sYAXg-DA-1; Tue, 30 Mar 2021 09:09:53 -0400 X-MC-Unique: x0-gZPDtNJmnr3sYAXg-DA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6A94A40C1; Tue, 30 Mar 2021 13:09:52 +0000 (UTC) Received: from redhat.com (ovpn-114-2.ams2.redhat.com [10.36.114.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C9D210016DB; Tue, 30 Mar 2021 13:09:43 +0000 (UTC) Date: Tue, 30 Mar 2021 14:09:40 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Subject: Re: Serious doubts about Gitlab CI Message-ID: References: <2d1e40c6-5fa4-271f-5ecc-74da7c04ffea@redhat.com> <20210319101848.ebdwkfttay73jajr@kamzik.brq.redhat.com> <04e5e251-7a09-dcf6-82ad-31bf696bc248@redhat.com> <902a93ca-bd71-504b-fcf5-fec2480f9ec0@redhat.com> MIME-Version: 1.0 In-Reply-To: <902a93ca-bd71-504b-fcf5-fec2480f9ec0@redhat.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Thomas Huth , Richard Henderson , Andrew Jones , Wainer dos Santos Moschetta , qemu-devel , Stefan Hajnoczi , Cleber Rosa , Alex =?utf-8?Q?Benn=C3=A9e?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Mar 30, 2021 at 02:09:38PM +0200, Paolo Bonzini wrote: > On 30/03/21 13:55, Thomas Huth wrote: > > > > Since the build system has been converted to meson, I think the > > configure script prefers to use the submodules instead of the distro > > packages. I've tried to remedy this a little bit here: > > > > https://gitlab.com/qemu-project/qemu/-/commit/db0108d5d846e9a8 > > > > ... but new jobs of course will use the submodules again if the author > > is not careful. > > Hmm... it should be the same (or if not it's a bug). > > > Also I wonder whether we could maybe even get rid of the capstone and slirp submodules in QEMU now > > At least for slirp, we probably want to stay more on the bleeding edge which > implies having to keep the submodule. Capstone and libfdt probably can go. I don't think we need to stay on the bleeding edge per-se in terms of what we build against We have a declared minimum version of libslirp that we absolutely must have in order to get the API we need for core featureset. If new APIs are introduced, it is quite reasonable for us to make their usage in QEMU conditional, just as we would for any other 3rd party library we use. The reason to have slirp as a submodule is just to avoid a functional regression on distros which don't have slirp available at all, and which we don't expect to introduce it. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|