From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2654EC433DB for ; Tue, 30 Mar 2021 13:13:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B61FD600CD for ; Tue, 30 Mar 2021 13:13:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B61FD600CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lREBw-0001Ab-QT for qemu-devel@archiver.kernel.org; Tue, 30 Mar 2021 09:13:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lREBB-0000k9-Uv for qemu-devel@nongnu.org; Tue, 30 Mar 2021 09:13:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33435) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lREB8-0004vM-MQ for qemu-devel@nongnu.org; Tue, 30 Mar 2021 09:13:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617109985; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xRA3CvNlXCd4A/ONKBoDitNcVyhzvKqKwr2aTA9z3vE=; b=bc6Ki8jwbnViAm0aukUbuH1bwjxMnQ8knsKsjMseVo8aHcQrfVh2O9Sb16RT2jc+R1e8fT 24fu7pwj6sftR5ztiQd5VOjgMreDSzfXB0RzpSit5Q+yQQbq/P412zubIpkvO9NFE8QPU8 H3tVmR1ke7GT2tDb1xcrELXxwF39Jtk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-476-0BWWyetTNVebynl77u3mig-1; Tue, 30 Mar 2021 09:13:03 -0400 X-MC-Unique: 0BWWyetTNVebynl77u3mig-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4DDAAA40C1; Tue, 30 Mar 2021 13:13:02 +0000 (UTC) Received: from redhat.com (ovpn-114-2.ams2.redhat.com [10.36.114.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FB6B1000358; Tue, 30 Mar 2021 13:12:44 +0000 (UTC) Date: Tue, 30 Mar 2021 14:12:42 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Subject: Re: Serious doubts about Gitlab CI Message-ID: References: <20210319101848.ebdwkfttay73jajr@kamzik.brq.redhat.com> <04e5e251-7a09-dcf6-82ad-31bf696bc248@redhat.com> <902a93ca-bd71-504b-fcf5-fec2480f9ec0@redhat.com> <1bb868bb-d9d7-3a9a-cbd4-2e1780b46442@redhat.com> MIME-Version: 1.0 In-Reply-To: <1bb868bb-d9d7-3a9a-cbd4-2e1780b46442@redhat.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Thomas Huth , qemu-devel , Richard Henderson , Andrew Jones , Wainer dos Santos Moschetta , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Cleber Rosa , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Alex =?utf-8?Q?Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Mar 30, 2021 at 02:45:43PM +0200, Paolo Bonzini wrote: > On 30/03/21 14:23, Philippe Mathieu-Daudé wrote: > > On 3/30/21 2:09 PM, Paolo Bonzini wrote: > > > On 30/03/21 13:55, Thomas Huth wrote: > > > > > > > > Also I wonder whether we could maybe even get rid of the capstone and > > > > slirp submodules in QEMU now > > > > > > At least for slirp, we probably want to stay more on the bleeding edge > > > which implies having to keep the submodule. > > > > FYI QEMU libSLiRP submodule doesn't point to bleeding edge branch but to > > the stable branch (which should be what distributions package). > > Now, but that may change already in 6.1 in order to add CFI support. We can bundle a newer version, but we don't need to require a newer version. Simply conditional compile for the bits we need. If distro slirp is too old, then sorry, you can't enable CFI + slirp at the same time. If the distro really wants that combination we don't have to own the solution - the distro should update their slirp. Or to put it another way, QEMU doesn't need to go out of its way to enable new features on old distros. We merely need to not regress in the features we previously offered. We bundled slirp as a submodule so that old distros didn't loose slirp entirely. We don't need to offer CFI on those distros. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|