From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B963C433ED for ; Thu, 1 Apr 2021 12:32:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 335AE61131 for ; Thu, 1 Apr 2021 12:32:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 335AE61131 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=NetBSD.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRwV6-0002Xo-SC for qemu-devel@archiver.kernel.org; Thu, 01 Apr 2021 08:32:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRwGM-0003MG-LM for qemu-devel@nongnu.org; Thu, 01 Apr 2021 08:17:26 -0400 Received: from 13thmonkey.org ([80.100.255.32]:60841 helo=diablo.13thmonkey.org) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRwGK-0006ST-LY for qemu-devel@nongnu.org; Thu, 01 Apr 2021 08:17:26 -0400 Received: by diablo.13thmonkey.org (Postfix, from userid 103) id 3F8B3C139C5; Thu, 1 Apr 2021 14:17:22 +0200 (CEST) Date: Thu, 1 Apr 2021 14:17:22 +0200 From: Reinoud Zandijk To: Paolo Bonzini Subject: Re: [PATCH v6 1/4] Add NVMM accelerator: configure and build logic Message-ID: References: <20210331200800.24168-1-reinoud@NetBSD.org> <20210331200800.24168-2-reinoud@NetBSD.org> <5251852d-19ac-11d1-6343-6e1156d81f3e@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1M8JQhQOgUbwGJNZ" Content-Disposition: inline In-Reply-To: <5251852d-19ac-11d1-6343-6e1156d81f3e@redhat.com> Received-SPF: none client-ip=80.100.255.32; envelope-from=reinoud@diablo.13thmonkey.org; helo=diablo.13thmonkey.org X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Richard Henderson , qemu-devel@nongnu.org, Kamil Rytarowski , Reinoud Zandijk , Ryo ONODERA Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --1M8JQhQOgUbwGJNZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Paolo, thanks for the review! On Thu, Apr 01, 2021 at 10:28:19AM +0200, Paolo Bonzini wrote: > On 31/03/21 22:07, Reinoud Zandijk wrote: > > Signed-off-by: Reinoud Zandijk > > Signed-off-by: Kamil Rytarowski > > Incorrect order for the S-o-b headers, you should be last. Oops? there is a prescribed order in those? Will change the order! > > --- > > @@ -886,7 +887,7 @@ for opt do > > ;; > > --python=*) python="$optarg" ; explicit_python=yes > > ;; > > - --sphinx-build=*) sphinx_build="$optarg" > > + --sphinx-build-3.8-3.8=*) sphinx_build="$optarg" > > Oops. :) Another occurrence later. Ai ai ai, a different patch krept in! In pkgsrc all patches on a single file are normally combined and thus they krept in! > > diff --git a/meson.build b/meson.build > > index c6f4b0cf5e..e33face775 100644 > > --- a/meson.build > > +++ b/meson.build > > The meson.build parts can be simplified by applying this patch: > > diff --git a/meson.build b/meson.build Thanks! Will try it out and add to the patch. > > @@ -625,7 +641,7 @@ if have_system and not get_option('curses').disabled() > > endif > > endif > > if not get_option('iconv').disabled() > > - foreach link_args : [ ['-liconv'], [] ] > > + foreach link_args : [ [], ['-liconv'] ] > > # Programs will be linked with glib and this will bring in libiconv on FreeBSD. > > # We need to use libiconv if available because mixing libiconv's headers with > > # the system libc does not work. > > Independent changes, should be posted separately. Yep, those shouldn't be in this patchset indeed, see above. Will try to fix it and go for version 7 soon. Is there a way for `qemu format-patch' to preserve the comments made in the previous run? It would be handy if it would paste in the old patchset's comments in the new patchset :) Reinoud --1M8JQhQOgUbwGJNZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEELRHWktq6GkG74/X0gpw3AEPIqmgFAmBluc8ACgkQgpw3AEPI qmiH4Af+LyvPVb+ipiTX1w1fV1JfjAivBy/cjvM0+cWxpVW2FbpuRzxfBE7VPCUg z9AqfH3Lo6+2PD7ncOm7PApfxJ2pr8b1PiCi9KVL9cLJPeDZTFow9mIZNCYDrBwt jgAoO4aYB0iqxYJvxbfljv59/1sYJgJQ6J7BEXt/d7EggZ531SGSGeSgTXjsE8Ik QmMCO5zAuT7aFMRwdjJjgam7EA3Y1P41MB/7sUyVpYFOcX0a1a3MOnVJ0b2bsEQI imwqRjSVFSXRIAwoaaxN74Zt/KDYA1TZOuTU5Qe1itBeZzwtPDwVxeOJ1aQvdu/E SI8B/x8XSmOuHLUXldHgAR18Bs+MdA== =KyoY -----END PGP SIGNATURE----- --1M8JQhQOgUbwGJNZ--