From: David Gibson <david@gibson.dropbear.id.au>
To: Daniel Henrique Barboza <danielhb413@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org
Subject: Re: [PATCH 2/2] spapr.h: increase FDT_MAX_SIZE
Date: Mon, 19 Apr 2021 15:41:51 +1000 [thread overview]
Message-ID: <YH0YHyqiyeobJC6U@yekko.fritz.box> (raw)
In-Reply-To: <20210408204049.221802-3-danielhb413@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]
On Thu, Apr 08, 2021 at 05:40:49PM -0300, Daniel Henrique Barboza wrote:
> Certain SMP topologies stress, e.g. 1 thread/core, 2048 cores and
> 1 socket, stress the current maximum size of the pSeries FDT:
>
> Calling ibm,client-architecture-support...qemu-system-ppc64: error
> creating device tree: (fdt_setprop(fdt, offset,
> "ibm,processor-segment-sizes", segs, sizeof(segs))): FDT_ERR_NOSPACE
>
> 2048 is the default NR_CPUS value for the pSeries kernel. It's expected
> that users will want QEMU to be able to handle this kind of
> configuration.
>
> Bumping FDT_MAX_SIZE to 2MB is enough for these setups to be created.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Applied to ppc-for-6.1, thanks.
> ---
> include/hw/ppc/spapr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
> index bf7cab7a2c..3deb382678 100644
> --- a/include/hw/ppc/spapr.h
> +++ b/include/hw/ppc/spapr.h
> @@ -95,7 +95,7 @@ typedef enum {
> #define SPAPR_CAP_FIXED_CCD 0x03
> #define SPAPR_CAP_FIXED_NA 0x10 /* Lets leave a bit of a gap... */
>
> -#define FDT_MAX_SIZE 0x100000
> +#define FDT_MAX_SIZE 0x200000
>
> /*
> * NUMA related macros. MAX_DISTANCE_REF_POINTS was taken
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-19 5:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 20:40 [PATCH 0/2] ppc64: do not use MachineClass::max_cpus to limit CPUs Daniel Henrique Barboza
2021-04-08 20:40 ` [PATCH 1/2] spapr.c: " Daniel Henrique Barboza
2021-04-19 5:40 ` David Gibson
2021-04-08 20:40 ` [PATCH 2/2] spapr.h: increase FDT_MAX_SIZE Daniel Henrique Barboza
2021-04-19 5:41 ` David Gibson [this message]
2021-04-29 14:03 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH0YHyqiyeobJC6U@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=danielhb413@gmail.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).