From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
Peter Xu <peterx@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH for-6.0] migration: Drop redundant query-migrate result @blocked
Date: Mon, 19 Apr 2021 18:26:03 +0100 [thread overview]
Message-ID: <YH29K3Wa/gyceh72@work-vm> (raw)
In-Reply-To: <CAFEAcA_S7rvB73JxEAUj_aKcxNcKu4zSoFUsXiLHb=kU7=Qs1A@mail.gmail.com>
* Peter Maydell (peter.maydell@linaro.org) wrote:
> On Mon, 19 Apr 2021 at 17:27, Markus Armbruster <armbru@redhat.com> wrote:
> >
> > Result @blocked is true when and only when result @blocked-reasons is
> > present. It's always non-empty when present. @blocked is redundant;
> > drop.
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
So I'm OK with it in principal and I think the code is OK, so
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> "for-6.0" needs to be accompanied by a justification of why it's
> important to go in the release at this point...
I guess the argument is that when we hit 6.0 it becomes API and removing
the 'blocked' becomes a matter of deprecation which is a pain.
Hmm; I agree it's the right change, but I'm not sure I can justify it
this late in the release.
Dave
> thanks
> -- PMM
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-04-19 17:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 16:27 [PATCH for-6.0] migration: Drop redundant query-migrate result @blocked Markus Armbruster
2021-04-19 16:32 ` Peter Maydell
2021-04-19 17:26 ` Dr. David Alan Gilbert [this message]
2021-04-20 4:27 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH29K3Wa/gyceh72@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).