From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D88E0C433B4 for ; Fri, 9 Apr 2021 11:18:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BB406113A for ; Fri, 9 Apr 2021 11:18:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BB406113A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUp9d-0004ix-0a for qemu-devel@archiver.kernel.org; Fri, 09 Apr 2021 07:18:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUp92-0004JQ-I3 for qemu-devel@nongnu.org; Fri, 09 Apr 2021 07:17:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUp8z-0005cP-91 for qemu-devel@nongnu.org; Fri, 09 Apr 2021 07:17:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617967064; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=EgnU/iXIKZMb+LzIC+MUlOgWLqUG3VBQfnnFHbr3QdE=; b=OV/qxEWuPC2qBqtEygbS/FNANwO1QLrEeP0IsZJYQvnc4cRsZZkNA0QqAOiVnJTacX/L8N 7oi2mbRMF5aqbfO5GmEZ/JBi7lNFbAow9gKiaxbIxtoSkka8y+RbFUpLe5mYo1GlYZl8mZ 82tocpS5bxk45zjcUTjFaYH32VRjyEo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-176-ZNExKzJiPe2RZtZea0IFvg-1; Fri, 09 Apr 2021 07:17:39 -0400 X-MC-Unique: ZNExKzJiPe2RZtZea0IFvg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 23A07107ACE4 for ; Fri, 9 Apr 2021 11:17:39 +0000 (UTC) Received: from redhat.com (ovpn-115-36.ams2.redhat.com [10.36.115.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7FAE060BE5; Fri, 9 Apr 2021 11:17:30 +0000 (UTC) Date: Fri, 9 Apr 2021 12:17:28 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Gerd Hoffmann Subject: Re: [PATCH v2] qemu-trace-stap: changing SYSTEMTAP_TAPSET considered harmful. Message-ID: References: <20210409105810.374976-1-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210409105810.374976-1-kraxel@redhat.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Apr 09, 2021 at 12:58:10PM +0200, Gerd Hoffmann wrote: > Setting SYSTEMTAP_TAPSET to some value other than > /usr/share/systemtap/tapsets results in systemtap not finding the > standard tapset library any more, which in turn breaks tracing because > pid() and other standard systemtap functions are not available any more. > > So using SYSTEMTAP_TAPSET to point systemtap to the qemu probes will > only work for the prefix=/usr installs because both qemu and system > tapsets in the same directory then. All other prefixes are broken. > > Fix that by using the "-I $tapsetdir" command line switch instead. Do you know if "-I tapsetdir" appends or prepends to the search path ? We need it to prepend to ensure that we override any QEMU stp files that might be already present in /usr/share from an RPM provided QEMU binary. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|