From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BF5AC433B4 for ; Thu, 22 Apr 2021 19:26:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 991C9613F6 for ; Thu, 22 Apr 2021 19:26:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 991C9613F6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZey3-0002oB-6t for qemu-devel@archiver.kernel.org; Thu, 22 Apr 2021 15:26:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZepZ-0006C4-V3; Thu, 22 Apr 2021 15:17:42 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:41099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZepV-0000my-Ni; Thu, 22 Apr 2021 15:17:41 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id A041C1AB5; Thu, 22 Apr 2021 15:17:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 22 Apr 2021 15:17:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=PvVOWPsHr15qvJ3+U7xVyRRsDtD 7CRVTzFUc6bUTr6c=; b=E4i0V66d1oH1gv+xnPhnvaA9cREJxXPWpY9K3q3CMDI qSXml5UkGyqTMBJzzgoUUQzZxoJTIBEA0EGFsWbmbtnPE3OpO9BFtRSDU72cG6Ai d+0iUVLHZYrOYbN5c7B8aMQ+Ehl3qXgoZ9N6saj5mOftuZkhXfuINwPh7q5D3Cc1 U3DxBSPSi0B7K0pjCOtpk6aIzL+dSgxmk7BGNGisB0aRaZM3rAkNJjHOIMLwK8Oo r7EP16F9XUGy9H9dNy03eDREu36JJ8Af6EOqQgSmY2fnhEiYwf3ukrnMzHrx7h4M eiqqXhTBsEDkvsIlRTZ4cou6P01LNfVX708COjdY19Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=PvVOWP sHr15qvJ3+U7xVyRRsDtD7CRVTzFUc6bUTr6c=; b=RdIPg1akMhobFWeT2ZSCeK q9JAftydj56V28H0UhSDJ/6f8cvb0IkRPUo42PvnIBWKDrJEggdx9pKTlaaILtlw 1TE8fDJuu4k5xUPHyNoc+bRdCl82a6FgClxPb0E1wB96rwGM9ZSXmRQTooK0KSVR pzMfsbZYM62lbVLwZboM3SnrvmTILvz9P+9FeRgnXTsNWTJd/CG4w/k8XZWQKCeJ QrBi3ZgpLNBoRfzWZo9tm1QI8w3PlM75S+DW/FBA4PFcyWTTBcbEanWc7Uxg1GHK JfnIl/y0K6S/eEaw+MTkT9YSPwUXb+Qqckch+MoHBR0Cs6q6vE39G3ZsNSqZ4H/w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddutddgudefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepjeegudffueeiteekieelkedvueelteevjeduieeludfffeejgeffhfduvddu ffeknecukfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 0633E24005A; Thu, 22 Apr 2021 15:17:28 -0400 (EDT) Date: Thu, 22 Apr 2021 21:17:27 +0200 From: Klaus Jensen To: Peter Maydell Subject: Re: [PATCH for-6.0? 0/1] hw/block/nvme: fix msix uninit Message-ID: References: <20210422135834.406688-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LWsU9ViqB6hN06kS" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=64.147.123.24; envelope-from=its@irrelevant.dk; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Qemu-block , Klaus Jensen , QEMU Developers , Max Reitz , Keith Busch Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --LWsU9ViqB6hN06kS Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline On Apr 22 19:58, Peter Maydell wrote: >On Thu, 22 Apr 2021 at 15:07, Klaus Jensen wrote: >> >> On Apr 22 15:58, Klaus Jensen wrote: >> >From: Klaus Jensen >> > >> >Hi Peter, >> > >> >The commit message on the patch describes the issue. This is a QEMU >> >crashing bug in -rc4 that I introduced early in the cycle and never >> >found in time. Lack of testing device hotplugging is the cause for that. >> > >> >I'm not sure what to say other than I'm terribly sorry for introducing >> >this and if this means an -rc5 needs to be rolled, then I'm even more >> >sorry. >> > >> >I think an acceptance test could have caught this, and I am already >> >working on an acceptance test suite for the nvme device, so I'll add >> >something that test this as well. But, well, it doesn't help now. > >> As far as I can tell, to cause this crash, monitor access is required, >> so I am not sure if we can get away with a note on this in the release >> notes and fix this in a potential stable release or next. > >Is this a regression since 5.2 ? > Yes. --LWsU9ViqB6hN06kS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmCBy8UACgkQTeGvMW1P DekLhAf9HtmHwJLV+La6VLYRZjxeBsOVO1fyj3P5pWmVZvlJFFgTC+vQIvBj6toy Go7LMVRaRnAzSkQ/Z05DYxKVUZeYvvXraPH+JoFfal9JcyJdv/Cusx8ii/15H27C f6xMQQw/Wg5lOdvDJRS4OrWMRa6YJMZpI9yaj9O3IsE38Tc4q16OVxTwNk7ud1hM OPQofhQU296s27jL/UJESqEF8k2A1YZRZEkg5oYvtYp+j7eGmiws7uAYQCw1js8J ynqz1l8PmUHKN1592a/7tmx8ApxALwx6hk6WvAYawafFDxQ3pXBhBdNO63VONjic Gb1FgfZ+0Ko+jJ1rBy0zgNDmer+7lw== =NTDe -----END PGP SIGNATURE----- --LWsU9ViqB6hN06kS--