From: "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>
To: Bruno Piazera Larsen <bruno.larsen@eldorado.org.br>
Cc: Fabiano Rosas <farosas@linux.ibm.com>,
Luis Fernando Fujita Pires <luis.pires@eldorado.org.br>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Lucas Mateus Martins Araujo e Castro
<lucas.araujo@eldorado.org.br>,
Fernando Eckhardt Valle <fernando.valle@eldorado.org.br>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
Matheus Kowalczuk Ferst <matheus.ferst@eldorado.org.br>
Subject: Re: [RFC PATCH 1/4] target/ppc: move opcode table logic to translate.c
Date: Tue, 27 Apr 2021 13:16:38 +1000 [thread overview]
Message-ID: <YIeCFk+yuLZbuTd2@yekko.fritz.box> (raw)
In-Reply-To: <CP2PR80MB44994743B9245C417246FBDAC7429@CP2PR80MB4499.lamprd80.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1722 bytes --]
On Mon, Apr 26, 2021 at 07:29:54PM +0000, Bruno Piazera Larsen wrote:
> > > code motion to remove opcode callback table from
> > > translate_init.c.inc to translate.c in preparation
> > > to remove #include <translate_init.c.inc> from
> > > translate.c
> >
> > I'd mention the creation of destroy_ppc_opcodes since this patch is not
> > strictly just moving code.
>
> Sure, will do for v2.
>
> > > +#if defined(PPC_DUMP_CPU)
> >
> > The commented out define for this was left behind.
>
> Good catch! The define is going to still be used by a couple of things in cpu_init, though.
> I'm guessing moving to internal.h is the best solution, but correct
> me if I'm wrong
Generally LGTM, excepting the things Fabiano pointed out.
>
>
> Bruno Piazera Larsen
>
> Instituto de Pesquisas ELDORADO<http://clickemailmkt.eldorado.org.br/ls/click?upn=UPoxpeIcHnAcbUZyo7TTaswyiVb1TXP3jEbQqiiJKKGsxOn8hBEs5ZsMLQfXkKuKXZ7MVDg0ij9eG8HV4TXI75dBzDiNGLxQ8Xx5PzCVNt6TpGrzBbU-2Biu0o69X5ce-2FW-2FOk1uUipuK0fZnWXJEgbRw-3D-3DJY4T_wWk-2BG6VvNBoa1YzxYjhCdFS9IfANIaBzDSklR1NyyrKOI1wj0P-2BdBFcuO4FnHcsA1MyHu0ly1Yt3oDMp7KKdJPM68iKuI2jiRH5v4B0d8wf3chU3qy5n5iXWnW1QjSaNFHOgELzxaP-2FnesTeBgJ5dFkjH4f279sVQpOtyjw5xAqj34M6pgNRAxVvuXif4IWDcVzXg1FzfYlEfkKzr9vvpA3Hg8kitwMtlU3zwbQUBCgL30fQoJPcRPMGKyOY8RmoAlXNqTJYDYIvqmfnI7KLUvw6vKB5R-2B5q1FJRAzX7H-2BmF0NnDET6jMLuIqtCcVIch>
>
> Departamento Computação Embarcada
>
> Analista de Software Trainee
>
> Aviso Legal - Disclaimer<https://www.eldorado.org.br/disclaimer.html>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-27 3:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 19:18 [RFC PATCH 0/4] target/ppc: code motion to compile translate_init Bruno Larsen (billionai)
2021-04-23 19:18 ` [RFC PATCH 1/4] target/ppc: move opcode table logic to translate.c Bruno Larsen (billionai)
2021-04-26 19:15 ` Fabiano Rosas
2021-04-26 19:29 ` Bruno Piazera Larsen
2021-04-27 3:16 ` david [this message]
2021-04-23 19:18 ` [RFC PATCH 2/4] target/ppc: isolated SPR read/write callbacks Bruno Larsen (billionai)
2021-04-26 20:06 ` Fabiano Rosas
2021-04-26 20:38 ` Bruno Piazera Larsen
2021-04-27 3:28 ` David Gibson
2021-04-23 19:18 ` [RFC PATCH 3/4] target/ppc: Move SPR generation to separate file Bruno Larsen (billionai)
2021-04-26 21:08 ` Fabiano Rosas
2021-04-27 3:35 ` David Gibson
2021-04-23 19:18 ` [RFC PATCH 4/4] target/ppc: isolated cpu init from translation logic Bruno Larsen (billionai)
2021-04-27 3:38 ` David Gibson
2021-04-23 23:43 ` [RFC PATCH 0/4] target/ppc: code motion to compile translate_init Richard Henderson
2021-04-26 11:51 ` Bruno Piazera Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIeCFk+yuLZbuTd2@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=bruno.larsen@eldorado.org.br \
--cc=farosas@linux.ibm.com \
--cc=fernando.valle@eldorado.org.br \
--cc=lucas.araujo@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).