From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61C8BC433ED for ; Tue, 27 Apr 2021 14:04:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E237A613DA for ; Tue, 27 Apr 2021 14:04:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E237A613DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbOKI-0001QL-Sp for qemu-devel@archiver.kernel.org; Tue, 27 Apr 2021 10:04:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbOIj-0000VW-6U for qemu-devel@nongnu.org; Tue, 27 Apr 2021 10:02:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57901) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbOIY-0004sQ-Mo for qemu-devel@nongnu.org; Tue, 27 Apr 2021 10:02:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619532165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xKGFtv9u+eyJck6rBS0sy0vvNEpATuUib8WEkQHAmjQ=; b=YA5XtDpPfipJ4OamCbH69tjLWXKGsL1oN04Dih8YIJ6VPhBqZbfCRQ2sY5Q6ItEX++Xv/A 3VVpacxZJpSnKqdmp8wxiT/zAChGK0WL/F7kDDqI32fGVpZ867QsKeO6b5EcLvOhOznezG hr8lUw5X4txcCyvdlV4UqJ1WNmkLwgo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-oarB0aV9MLyoypKQ8XEhAQ-1; Tue, 27 Apr 2021 10:02:41 -0400 X-MC-Unique: oarB0aV9MLyoypKQ8XEhAQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 26D6A8049CE for ; Tue, 27 Apr 2021 14:02:41 +0000 (UTC) Received: from work-vm (ovpn-114-253.ams2.redhat.com [10.36.114.253]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ADB9810016DB; Tue, 27 Apr 2021 14:02:36 +0000 (UTC) Date: Tue, 27 Apr 2021 15:02:34 +0100 From: "Dr. David Alan Gilbert" To: Laurent Vivier Subject: Re: [PATCH] virtio-net: failover: add missing remove_migration_state_change_notifier() Message-ID: References: <20210427135147.111218-1-lvivier@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210427135147.111218-1-lvivier@redhat.com> User-Agent: Mutt/2.0.6 (2021-03-06) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.218, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , Jason Wang , qemu-devel@nongnu.org, "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Laurent Vivier (lvivier@redhat.com) wrote: > In the failover case configuration, virtio_net_device_realize() uses an > add_migration_state_change_notifier() to add a state notifier, but this > notifier is not removed by the unrealize function when the virtio-net > card is unplugged. > > If the card is unplugged and a migration is started, the notifier is > called and as it is not valid anymore QEMU crashes. > > This patch fixes the problem by adding the > remove_migration_state_change_notifier() in virtio_net_device_unrealize(). > > The problem can be reproduced with: > > $ qemu-system-x86_64 -enable-kvm -m 1g -M q35 \ > -device pcie-root-port,slot=4,id=root1 \ > -device pcie-root-port,slot=5,id=root2 \ > -device virtio-net-pci,id=net1,mac=52:54:00:6f:55:cc,failover=on,bus=root1 \ > -monitor stdio disk.qcow2 > (qemu) device_del net1 > (qemu) migrate "exec:gzip -c > STATEFILE.gz" > > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > 0x0000000000000000 in ?? () > (gdb) bt > #0 0x0000000000000000 in () > #1 0x0000555555d726d7 in notifier_list_notify (...) > at .../util/notify.c:39 > #2 0x0000555555842c1a in migrate_fd_connect (...) > at .../migration/migration.c:3975 > #3 0x0000555555950f7d in migration_channel_connect (...) > error@entry=0x0) at .../migration/channel.c:107 > #4 0x0000555555910922 in exec_start_outgoing_migration (...) > at .../migration/exec.c:42 > > Reported-by: Igor Mammedov > Signed-off-by: Laurent Vivier Yep, I think that's OK. Reviewed-by: Dr. David Alan Gilbert > --- > hw/net/virtio-net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index 66b9ff451185..914051feb75b 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -3373,6 +3373,7 @@ static void virtio_net_device_unrealize(DeviceState *dev) > > if (n->failover) { > device_listener_unregister(&n->primary_listener); > + remove_migration_state_change_notifier(&n->migration_state); > } > > max_queues = n->multiqueue ? n->max_queues : 1; > -- > 2.30.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK