From: Klaus Jensen <its@irrelevant.dk>
To: Bug 1925496 <1925496@bugs.launchpad.net>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Bug 1925496] Re: nvme disk cannot be hotplugged after removal
Date: Wed, 28 Apr 2021 12:12:56 +0200 [thread overview]
Message-ID: <YIk1KG4dgT6mwChA@apples.localdomain> (raw)
In-Reply-To: <161960231059.11681.2408216748859225156.malone@wampee.canonical.com>
[-- Attachment #1: Type: text/plain, Size: 988 bytes --]
On Apr 28 09:31, Oguz Bektas wrote:
>> My understanding is that this is the expected behavior. The reason is
>> that the drive cannot be deleted immediately when the device is
>> hot-unplugged, since it might not be safe (other parts of QEMU could
>> be using it, like background block jobs).
>>
>> On the other hand, the fact that if the drive is removed explicitly
>> through QMP (or in the monitor with drive_del), the drive id is
>> remains "in use". This might be a completely different bug that is
>> unrelated to the nvme device.
>
>using the same commands I can hot-plug and hot-unplug a scsi disk like
>this without issue - this behavior only appeared on nvme devices.
>
Kevin, Max, can you shed any light on this?
Specifically what the expected behavior is wrt. to the drive when
unplugging a device that has one attached?
If the scsi disk is capable of "cleaning up" immediately, then I suppose
that some steps are missing in the nvme unrealization.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-04-28 10:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 12:34 [Bug 1925496] [NEW] nvme disk cannot be hotplugged after removal Oguz Bektas
2021-04-22 12:55 ` [Bug 1925496] " Klaus Jensen
2021-04-22 13:38 ` Oguz Bektas
2021-04-22 14:24 ` Klaus Jensen
2021-04-26 9:31 ` Oguz Bektas
2021-04-28 7:38 ` Klaus Jensen
2021-04-28 9:31 ` Oguz Bektas
2021-04-28 10:12 ` Klaus Jensen [this message]
2021-04-28 13:00 ` Max Reitz
2021-05-03 7:27 ` Klaus Jensen
2021-05-11 7:37 ` Hannes Reinecke
2021-05-18 4:32 ` Thomas Huth
2021-06-16 14:54 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIk1KG4dgT6mwChA@apples.localdomain \
--to=its@irrelevant.dk \
--cc=1925496@bugs.launchpad.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).