From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DFADC433ED for ; Tue, 4 May 2021 10:47:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA0EA611AB for ; Tue, 4 May 2021 10:47:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA0EA611AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldsa6-00011U-UN for qemu-devel@archiver.kernel.org; Tue, 04 May 2021 06:47:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldsYj-0008Jk-9K for qemu-devel@nongnu.org; Tue, 04 May 2021 06:45:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27910) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldsYh-0001pa-GV for qemu-devel@nongnu.org; Tue, 04 May 2021 06:45:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620125141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WNvIUQ0yYbgxw7ysw/CjpudXJM2XffOxG8VvL5/4UGk=; b=NbUYmcLj1+WkaXsyUxg1ix2+CB6OQjmMabgo4W1uVkoNtFESeY3SN0hIdGmHY1ObFvoYCp SwbBrVa2M4GZKn5c5ZlaQ1A92iuVvJdGYiml0DqWVA9ottNDDnluCbZ+3UrcNlCQgZAjLC HITB3zcUX2ceuU2r8GC47YissTv2Oak= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-spaOZRZSOVGCjGtVLNFYLA-1; Tue, 04 May 2021 06:45:38 -0400 X-MC-Unique: spaOZRZSOVGCjGtVLNFYLA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1AB6150212; Tue, 4 May 2021 10:45:37 +0000 (UTC) Received: from work-vm (ovpn-115-50.ams2.redhat.com [10.36.115.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E678859446; Tue, 4 May 2021 10:45:20 +0000 (UTC) Date: Tue, 4 May 2021 11:45:18 +0100 From: "Dr. David Alan Gilbert" To: Peter Krempa Subject: Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property Message-ID: References: <20210429155221.1226561-1-stefanha@redhat.com> <20210429180352.ohhfz4kwyxapbiyl@habkost.net> <87lf905icy.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.6 (2021-03-06) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , libvir-list@redhat.com, Markus Armbruster , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz , Christoph Hellwig Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Peter Krempa (pkrempa@redhat.com) wrote: > On Fri, Apr 30, 2021 at 09:42:05 +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > On Thu, Apr 29, 2021 at 04:52:21PM +0100, Stefan Hajnoczi wrote: > > >> The scsi=on|off property was deprecated in QEMU 5.0 and can be removed > > >> completely at this point. > > >> > > >> Drop the scsi=on|off option. It was only available on Legacy virtio-blk > > >> devices. Linux v5.6 already dropped support for it. > > >> > > >> Remove the hw_compat_2_4[] property assignment since scsi=on|off no > > >> longer exists. Old guests with Legacy virtio-blk devices no longer see > > >> the SCSI host features bit. > > >> > > > > > > This means pc-2.4 will now break guest ABI if using virtio-blk > > > devices, correct? > > > > > > This looks like a sign we should have deprecated pc-2.4 a long > > > time ago. > > > > The last batch of PC machine type retiring was pc-1.0 to pc-1.3: > > deprecated in 5.0 (commit 30d2a17b4, Dec 2019), dropped in 6.0 (commit > > f862ddbb1, just weeks ago). pc-1.3 was a bit over seven years old when > > we released 5.0. pc-2.4 will be six years old by the time we release > > 6.1. Fair game? > > As a data-point, libvirt will be dropping support for (release, not the machine type) in the upcomming release. I'm not sure > whether that justifies more deprecation though. What qemu features will you then be relying on? Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK