From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4351FC433ED for ; Wed, 5 May 2021 10:54:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B0CF610FA for ; Wed, 5 May 2021 10:54:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B0CF610FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leFAH-0001Pn-EQ for qemu-devel@archiver.kernel.org; Wed, 05 May 2021 06:54:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leF8n-0000b2-N6 for qemu-devel@nongnu.org; Wed, 05 May 2021 06:52:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36685) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leF8k-0007Ux-2m for qemu-devel@nongnu.org; Wed, 05 May 2021 06:52:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620211944; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jcr0sZVtGy0QyodyGTD/QilUyY6MXlJnnT/JXieunPg=; b=Ycj2CJUx7vIqmiX5xsRi2cd/VSGTmSEIbU6Boi6nkx6WcFhw/SvOsGAa5zuy6EOYApDuwl 1nY+fmmc0TCorf/2wEibh2zDZNb3/jyraN4YzTMKpLhr4pNhrzzFHKPE9IrGj0YI9l6Sjn F/sAXbJrKKrgM99B7ADBGRi08k3dQ4c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-SkxO7NO9MAaIIjoPXU9koQ-1; Wed, 05 May 2021 06:52:20 -0400 X-MC-Unique: SkxO7NO9MAaIIjoPXU9koQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A8B1A803620; Wed, 5 May 2021 10:52:18 +0000 (UTC) Received: from redhat.com (ovpn-114-253.ams2.redhat.com [10.36.114.253]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9ADB1421F; Wed, 5 May 2021 10:52:08 +0000 (UTC) Date: Wed, 5 May 2021 11:52:05 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v1 5/7] docs: mark intention to deprecate TCG tracing functionality Message-ID: References: <20210505092259.8202-1-alex.bennee@linaro.org> <20210505092259.8202-6-alex.bennee@linaro.org> <87lf8to49d.fsf@linaro.org> <87im3xo3zv.fsf@linaro.org> MIME-Version: 1.0 In-Reply-To: <87im3xo3zv.fsf@linaro.org> User-Agent: Mutt/2.0.6 (2021-03-06) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.697, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: "reviewer:Incompatible changes" , qemu-devel@nongnu.org, robhenry@microsoft.com, aaron@os.amperecomputing.com, vilanova@imperial.ac.uk, mahmoudabdalghany@outlook.com, minyihh@uci.edu, cota@braap.org, stefanha@redhat.com, mohamad.gebai@gmail.com, kuhn.chenqun@huawei.com, matheus.ferst@eldorado.org.br Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, May 05, 2021 at 11:41:46AM +0100, Alex Bennée wrote: > > Alex Bennée writes: > > > Daniel P. Berrangé writes: > > > >> On Wed, May 05, 2021 at 10:22:57AM +0100, Alex Bennée wrote: > > >>> +TCG introspection features > >>> +-------------------------- > >>> + > >>> +TCG trace-events (since 6.1) > >>> +'''''''''''''''''''''''''''' > >>> + > >>> +The ability to add new TCG trace points has bit rotted and as the > >> > >> When you say this "has bit rotted", just how bad is the situation ? > >> > >> Is the TCG tracing still usable at all, or is is fully broken > >> already ? > > > > Well patches 6/7 got it working for generic TCG things. I haven't been > > able to get the architecture one working but I suspect that is some sort > > of interaction between the per-arch trace header generation that I > > haven't quite figured out yet. > > Ahh it's since 7609ffb919 (trace: fix tcg tracing build breakage) which > limited tcg/vcpu events to the root trace-events file. That commit is from release 2.10.0. The other commit mentioned in patch 6 (73ff061032) is from 2.12.0. So no one has been able to use this feature for 3+ years already. Is it actually worth fixing and then deprecating for 2 releases before deleting, as opposed to just deleting the broken code today on basis that it can't have any current users ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|