From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: virtio-fs@redhat.com,
Carlos Venegas <jose.carlos.venegas.munoz@intel.com>,
qemu-devel@nongnu.org, vgoyal@redhat.com
Subject: Re: [Virtio-fs] [PATCH 1/2] virtiofsd: Allow use "-o xattrmap" without "-o xattr"
Date: Thu, 6 May 2021 11:00:05 +0100 [thread overview]
Message-ID: <YJO+JVvEU3BM0SWi@work-vm> (raw)
In-Reply-To: <20210416130537.2046bd26@bahia.lan>
* Greg Kurz (groug@kaod.org) wrote:
> On Wed, 14 Apr 2021 20:12:06 +0000
> Carlos Venegas <jose.carlos.venegas.munoz@intel.com> wrote:
>
> > When -o xattrmap is used, it will not work unless xattr is enabled.
> >
> > This patch enables xattr when -o xattrmap is used.
> >
> > Signed-off-by: Carlos Venegas <jose.carlos.venegas.munoz@intel.com>
> > ---
> > tools/virtiofsd/passthrough_ll.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> > index ddaf57305c..2337ea5a58 100644
> > --- a/tools/virtiofsd/passthrough_ll.c
> > +++ b/tools/virtiofsd/passthrough_ll.c
> > @@ -3939,6 +3939,7 @@ int main(int argc, char *argv[])
> > }
> >
> > if (lo.xattrmap) {
> > + lo.xattr = 1;
> > parse_xattrmap(&lo);
> > }
> >
>
> This seems reasonable. I'm just wondering if we should also
> add an explicit error if the user tries something silly
> like -o xattrmap=MAPPING,no_xattr instead of silently
> ignoring no_xattr...
That would be a nice addition, although I'll take this set is for now.
Dave
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://listman.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-05-06 10:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 20:12 [PATCH 0/2] virtiofsd: Enable xattr if xattrmap is used Carlos Venegas
2021-04-14 20:12 ` [PATCH 1/2] virtiofsd: Allow use "-o xattrmap" without "-o xattr" Carlos Venegas
2021-04-16 11:05 ` [Virtio-fs] " Greg Kurz
2021-04-19 18:55 ` Vivek Goyal
2021-05-06 10:00 ` Dr. David Alan Gilbert [this message]
2021-04-14 20:12 ` [PATCH 2/2] virtiofsd: Add help for -o xattr-mapping Carlos Venegas
2021-04-14 21:44 ` [Virtio-fs] " Connor Kuehl
2021-04-19 19:07 ` Vivek Goyal
2021-04-19 19:21 ` Connor Kuehl
2021-04-19 19:59 ` Vivek Goyal
2021-04-14 21:47 ` [PATCH 0/2] virtiofsd: Enable xattr if xattrmap is used Connor Kuehl
2021-05-06 15:52 ` Dr. David Alan Gilbert
2021-05-06 15:55 ` Venegas Munoz, Jose Carlos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJO+JVvEU3BM0SWi@work-vm \
--to=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=jose.carlos.venegas.munoz@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).