From: David Gibson <david@gibson.dropbear.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/2] ppc/pnv: Add support for the POWER10 DD2 CPU
Date: Mon, 10 May 2021 15:53:50 +1000 [thread overview]
Message-ID: <YJjKbhmdoTApPrqC@yekko> (raw)
In-Reply-To: <20210505090609.593194-1-clg@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
On Wed, May 05, 2021 at 11:06:07AM +0200, Cédric Le Goater wrote:
> Hello,
>
> The POWER10 DD2 CPU adds an extra LPCR[HAIL] bit which is a requirement
> to support the scv instruction on PowerNV POWER10 platforms (glibc-2.33).
>
> These changes add a POWER10 DD2 CPU and switch the default chip model
> of the powernv10 machine to use this CPU. This to make sure that the
> machine can boot the latest distros.
LGTM as far as it goes. Couple of points
* I'd prefer to combine the two patches together, basically
atomically replacing DD1 with DD2
* I'd like to sort out the DAWR1 support first, or at the same time.
I think it's reasonable to treat anything about POWER10 emulation
as experimental and unstable until we put an actually publically
available chip in there. If we sort out DAWR1 support now, it
means we can avoid having another spapr capability flag to handle
the case of qemu versions that support DD2, but not DAWR1.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-05-10 5:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 9:06 [PATCH 0/2] ppc/pnv: Add support for the POWER10 DD2 CPU Cédric Le Goater
2021-05-05 9:06 ` [PATCH 1/2] ppc: Add a " Cédric Le Goater
2021-05-05 9:06 ` [PATCH 2/2] ppc/pnv: Add support for the " Cédric Le Goater
2021-05-10 5:53 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJjKbhmdoTApPrqC@yekko \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).