From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: virtio-fs@redhat.com, ckuehl@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 0/7] virtiofsd: Few cleanups in virtio_send_data_iov()
Date: Tue, 25 May 2021 19:49:15 +0100 [thread overview]
Message-ID: <YK1Gq663KZxQPlVI@work-vm> (raw)
In-Reply-To: <20210518213538.693422-1-vgoyal@redhat.com>
* Vivek Goyal (vgoyal@redhat.com) wrote:
> Hi,
>
> This is V2 of the patches. Changes since V1 are.
>
> - Took care of coding style issue.
> - Got rid of label "err" completely in last patch. (Dave, Connor).
> - Captured Reviewed-by tags from Connor and David.
>
> Code in virtio_send_data_iov() little twisted and complicated. This
> patch series just tries to simplify it a bit to make it little easier
> to read this piece of code.
Queued
> Thanks
> Vivek
>
>
> Vivek Goyal (7):
> virtiofsd: Check for EINTR in preadv() and retry
> virtiofsd: Get rid of unreachable code in read
> virtiofsd: Use iov_discard_front() to skip bytes
> virtiofsd: get rid of in_sg_left variable
> virtiofsd: Simplify skip byte logic
> virtiofsd: Check EOF before short read
> virtiofsd: Set req->reply_sent right after sending reply
>
> tools/virtiofsd/fuse_virtio.c | 81 +++++++++++------------------------
> 1 file changed, 25 insertions(+), 56 deletions(-)
>
> --
> 2.25.4
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2021-05-25 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 21:35 [PATCH v2 0/7] virtiofsd: Few cleanups in virtio_send_data_iov() Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 1/7] virtiofsd: Check for EINTR in preadv() and retry Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 2/7] virtiofsd: Get rid of unreachable code in read Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 3/7] virtiofsd: Use iov_discard_front() to skip bytes Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 4/7] virtiofsd: get rid of in_sg_left variable Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 5/7] virtiofsd: Simplify skip byte logic Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 6/7] virtiofsd: Check EOF before short read Vivek Goyal
2021-05-18 21:35 ` [PATCH v2 7/7] virtiofsd: Set req->reply_sent right after sending reply Vivek Goyal
2021-05-25 18:49 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK1Gq663KZxQPlVI@work-vm \
--to=dgilbert@redhat.com \
--cc=ckuehl@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).