From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C39C47089 for ; Thu, 27 May 2021 08:11:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD77A6139A for ; Thu, 27 May 2021 08:11:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD77A6139A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmB6d-00064X-Rs for qemu-devel@archiver.kernel.org; Thu, 27 May 2021 04:11:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmB5m-0005A1-3a for qemu-devel@nongnu.org; Thu, 27 May 2021 04:10:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmB5j-0007jt-Fb for qemu-devel@nongnu.org; Thu, 27 May 2021 04:10:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622103007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a6c1A+bUI6PVizBjLj5qmAQDvKblaoTpwViWy+tLw78=; b=DQdAWciSbMR+spPZ7SSTujt7l94ZXmceJNBV1amc/2jDU2p8DpYQiy1SK1c/K48s3+mrig hIphB5SWgMbOuRnEhb+/e2QmtRwQjKKNXhXU5AdG3lP/VcsBPW41gJK15At38Dl1Z1BXHO gz6+zQL+5MFZMieojfXiOLN6jG4GZFE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-EfNk0huRNpK93o0lXxyU7w-1; Thu, 27 May 2021 04:10:02 -0400 X-MC-Unique: EfNk0huRNpK93o0lXxyU7w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D3B44180FD65; Thu, 27 May 2021 08:10:00 +0000 (UTC) Received: from work-vm (ovpn-114-249.ams2.redhat.com [10.36.114.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62AED1658F; Thu, 27 May 2021 08:09:58 +0000 (UTC) Date: Thu, 27 May 2021 09:09:55 +0100 From: "Dr. David Alan Gilbert" To: Greg Kurz Subject: Re: [PATCH 4/5] monitor: removed cpustats command Message-ID: References: <20210526202104.127910-1-bruno.larsen@eldorado.org.br> <20210526202104.127910-5-bruno.larsen@eldorado.org.br> <20210527084038.512c5270@bahia.lan> MIME-Version: 1.0 In-Reply-To: <20210527084038.512c5270@bahia.lan> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: farosas@linux.ibm.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, Markus Armbruster , lucas.araujo@eldorado.org.br, luis.pires@eldorado.org.br, fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Greg Kurz (groug@kaod.org) wrote: > On Wed, 26 May 2021 17:21:03 -0300 > "Bruno Larsen (billionai)" wrote: > > > Since ppc was the last architecture to collect these statistics and > > it is currently phasing this collection out, the command that would query > > this information is being removed. > > > > So this is removing an obviously user visible feature. This should be > mentioned in docs/system/removed-features.rst... but, wait, I don't > see anything for it in docs/system/deprecated.rst. This is dropping > a feature without following the usual deprecation policy, i.e. > marking the feature as deprecated and only remove it 2 QEMU versions > later. Any justification for that ? As long as the command really isn't useful any more, I wouldn't object to that from an HMP point of view. Dave > David, > > Unrelated, I saw that you already applied this to ppc-for-6.1 on gitlab > but the commit title appears to be broken: > > '65;6401;1cmonitor: removed cpustats command > > https://gitlab.com/dgibson/qemu/-/commit/532be563eae6b8ae834ff7e9ebb1428f53569a69 > > > Suggested-by: Richard Henderson > > Signed-off-by: Bruno Larsen (billionai) > > --- > > hmp-commands-info.hx | 13 ------------- > > monitor/misc.c | 11 ----------- > > 2 files changed, 24 deletions(-) > > > > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx > > index ab0c7aa5ee..b2347a6aea 100644 > > --- a/hmp-commands-info.hx > > +++ b/hmp-commands-info.hx > > @@ -500,19 +500,6 @@ SRST > > Show the current VM UUID. > > ERST > > > > - { > > - .name = "cpustats", > > - .args_type = "", > > - .params = "", > > - .help = "show CPU statistics", > > - .cmd = hmp_info_cpustats, > > - }, > > - > > -SRST > > - ``info cpustats`` > > - Show CPU statistics. > > -ERST > > - > > #if defined(CONFIG_SLIRP) > > { > > .name = "usernet", > > diff --git a/monitor/misc.c b/monitor/misc.c > > index f3a393ea59..1539e18557 100644 > > --- a/monitor/misc.c > > +++ b/monitor/misc.c > > @@ -369,17 +369,6 @@ static void hmp_info_history(Monitor *mon, const QDict *qdict) > > } > > } > > > > -static void hmp_info_cpustats(Monitor *mon, const QDict *qdict) > > -{ > > - CPUState *cs = mon_get_cpu(mon); > > - > > - if (!cs) { > > - monitor_printf(mon, "No CPU available\n"); > > - return; > > - } > > - cpu_dump_statistics(cs, 0); > > -} > > - > > static void hmp_info_trace_events(Monitor *mon, const QDict *qdict) > > { > > const char *name = qdict_get_try_str(qdict, "name"); > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK