From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-stable@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH 3/3] vl: plug -object back into -readconfig
Date: Wed, 19 May 2021 18:41:49 +0200 [thread overview]
Message-ID: <YKU/zY2hjRC+ZsUC@merkur.fritz.box> (raw)
In-Reply-To: <20210518154059.3002446-3-pbonzini@redhat.com>
Am 18.05.2021 um 17:40 hat Paolo Bonzini geschrieben:
> Commit bc2f4fcb1d ("qom: move user_creatable_add_opts logic to vl.c
> and QAPIfy it", 2021-03-19) switched the creation of objects from
> qemu_opts_foreach to a bespoke QTAILQ in preparation for supporting JSON
> syntax in -object.
>
> Unfortunately in doing so it lost support for [object] stanzas in
> configuration files and also for "-set object.ID.KEY=VAL". The latter
> is hard to re-establish and probably best solved by deprecating -set.
> This patch uses the infrastructure introduced by the previous two
> patches in order to parse QOM objects correctly from configuration
> files.
>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2021-05-19 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 15:40 [PATCH 0/3] vl: add -object support back into -readconfig Paolo Bonzini
2021-05-18 15:40 ` [PATCH 1/3] qemu-config: parse configuration files to a QDict Paolo Bonzini
2021-05-19 14:40 ` Kevin Wolf
2021-05-20 7:41 ` Paolo Bonzini
2021-05-18 15:40 ` [PATCH 2/3] vl: plumb keyval-based options into -readconfig Paolo Bonzini
2021-05-19 16:35 ` Kevin Wolf
2021-05-18 15:40 ` [PATCH 3/3] vl: plug -object back " Paolo Bonzini
2021-05-19 16:41 ` Kevin Wolf [this message]
2021-05-19 13:58 ` [PATCH 0/3] vl: add -object support " Kevin Wolf
2021-05-19 14:46 ` Paolo Bonzini
2021-05-19 14:09 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKU/zY2hjRC+ZsUC@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).