From: David Gibson <david@gibson.dropbear.id.au>
To: "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br>
Cc: farosas@linux.ibm.com, richard.henderson@linaro.org,
qemu-devel@nongnu.org, lucas.araujo@eldorado.org.br,
fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org,
matheus.ferst@eldorado.org.br, luis.pires@eldorado.org.br
Subject: Re: [PATCH v3 5/9] target/ppc: removed unnecessary inclusion of helper-proto.h
Date: Mon, 24 May 2021 12:41:37 +1000 [thread overview]
Message-ID: <YKsSYfjATZUpCQdt@yekko> (raw)
In-Reply-To: <20210521201759.85475-6-bruno.larsen@eldorado.org.br>
[-- Attachment #1: Type: text/plain, Size: 2298 bytes --]
On Fri, May 21, 2021 at 05:17:55PM -0300, Bruno Larsen (billionai) wrote:
> These files included helper-proto.h, but didn't use or declare any
> helpers, so the #include has been removed
>
> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Applied to ppc-for-6.1, thanks.
> ---
> target/ppc/cpu_init.c | 1 -
> target/ppc/gdbstub.c | 1 -
> target/ppc/mmu-hash32.c | 1 -
> target/ppc/mmu-radix64.c | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
> index 3365135896..b696469d1a 100644
> --- a/target/ppc/cpu_init.c
> +++ b/target/ppc/cpu_init.c
> @@ -43,7 +43,6 @@
> #include "fpu/softfloat.h"
> #include "qapi/qapi-commands-machine-target.h"
>
> -#include "exec/helper-proto.h"
> #include "helper_regs.h"
> #include "internal.h"
> #include "spr_tcg.h"
> diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c
> index c7d866cfcc..09ff1328d4 100644
> --- a/target/ppc/gdbstub.c
> +++ b/target/ppc/gdbstub.c
> @@ -20,7 +20,6 @@
> #include "qemu/osdep.h"
> #include "cpu.h"
> #include "exec/gdbstub.h"
> -#include "exec/helper-proto.h"
> #include "internal.h"
>
> static int ppc_gdb_register_len_apple(int n)
> diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c
> index 32d1f4a954..6a07c345e4 100644
> --- a/target/ppc/mmu-hash32.c
> +++ b/target/ppc/mmu-hash32.c
> @@ -21,7 +21,6 @@
> #include "qemu/osdep.h"
> #include "cpu.h"
> #include "exec/exec-all.h"
> -#include "exec/helper-proto.h"
> #include "sysemu/kvm.h"
> #include "kvm_ppc.h"
> #include "internal.h"
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index eabfe4e261..cbd404bfa4 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -20,7 +20,6 @@
> #include "qemu/osdep.h"
> #include "cpu.h"
> #include "exec/exec-all.h"
> -#include "exec/helper-proto.h"
> #include "qemu/error-report.h"
> #include "sysemu/kvm.h"
> #include "kvm_ppc.h"
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-05-24 3:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 20:17 [PATCH v3 0/9] target/ppc: add support to disable-tcg Bruno Larsen (billionai)
2021-05-21 20:17 ` [PATCH v3 1/9] target/ppc: cleaned error_report from ppc_store_sdr1 Bruno Larsen (billionai)
2021-05-24 2:36 ` David Gibson
2021-05-21 20:17 ` [PATCH v3 2/9] target/ppc: moved ppc_store_lpcr and ppc_store_msr to cpu.c Bruno Larsen (billionai)
2021-05-24 2:37 ` David Gibson
2021-05-21 20:17 ` [PATCH v3 3/9] target/ppc: reduce usage of fpscr_set_rounding_mode Bruno Larsen (billionai)
2021-05-24 2:38 ` David Gibson
2021-05-21 20:17 ` [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fpscr Bruno Larsen (billionai)
2021-05-24 2:41 ` David Gibson
2021-05-25 2:01 ` Richard Henderson
2021-05-25 3:15 ` David Gibson
2021-05-21 20:17 ` [PATCH v3 5/9] target/ppc: removed unnecessary inclusion of helper-proto.h Bruno Larsen (billionai)
2021-05-24 2:41 ` David Gibson [this message]
2021-05-21 20:17 ` [PATCH v3 6/9] target/ppc: moved ppc_cpu_do_interrupt to cpu.c Bruno Larsen (billionai)
2021-05-24 2:57 ` David Gibson
2021-05-25 2:11 ` Richard Henderson
2021-05-21 20:17 ` [PATCH v3 7/9] target/ppc: Added options to disable many TCG-only functions Bruno Larsen (billionai)
2021-05-24 3:01 ` David Gibson
2021-05-21 20:17 ` [PATCH v3 8/9] target/ppc: created tcg-stub.c file Bruno Larsen (billionai)
2021-05-24 3:02 ` David Gibson
2021-05-24 12:54 ` Bruno Piazera Larsen
2021-05-21 20:17 ` [PATCH v3 9/9] target/ppc: updated meson.build to support disable-tcg Bruno Larsen (billionai)
2021-05-25 2:13 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKsSYfjATZUpCQdt@yekko \
--to=david@gibson.dropbear.id.au \
--cc=bruno.larsen@eldorado.org.br \
--cc=farosas@linux.ibm.com \
--cc=fernando.valle@eldorado.org.br \
--cc=lucas.araujo@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).