From: David Gibson <david@gibson.dropbear.id.au>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: farosas@linux.ibm.com, qemu-devel@nongnu.org,
lucas.araujo@eldorado.org.br, fernando.valle@eldorado.org.br,
qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br,
luis.pires@eldorado.org.br
Subject: Re: [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fpscr
Date: Tue, 25 May 2021 13:15:41 +1000 [thread overview]
Message-ID: <YKxr3TXsYbh58/M4@yekko> (raw)
In-Reply-To: <1d9a521f-4f1a-e91b-fe1a-4f0e14cebd6c@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
On Mon, May 24, 2021 at 07:01:20PM -0700, Richard Henderson wrote:
> On 5/21/21 1:17 PM, Bruno Larsen (billionai) wrote:
> > + uint32_t mask = 1u << bit;
> > + if (env->fpscr & mask) {
> > + ppc_store_fpscr(env, env->fpscr & ~mask);
>
> Oops, missed this during review but:
>
> fpscr & ~(target_ulong)mask;
>
> Otherwise we clear high bits of fpscr incorrectly.
Oops, good point. I've removed the previous version from ppc-for-6.1,
and I'll wait for a respin.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-05-25 3:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 20:17 [PATCH v3 0/9] target/ppc: add support to disable-tcg Bruno Larsen (billionai)
2021-05-21 20:17 ` [PATCH v3 1/9] target/ppc: cleaned error_report from ppc_store_sdr1 Bruno Larsen (billionai)
2021-05-24 2:36 ` David Gibson
2021-05-21 20:17 ` [PATCH v3 2/9] target/ppc: moved ppc_store_lpcr and ppc_store_msr to cpu.c Bruno Larsen (billionai)
2021-05-24 2:37 ` David Gibson
2021-05-21 20:17 ` [PATCH v3 3/9] target/ppc: reduce usage of fpscr_set_rounding_mode Bruno Larsen (billionai)
2021-05-24 2:38 ` David Gibson
2021-05-21 20:17 ` [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fpscr Bruno Larsen (billionai)
2021-05-24 2:41 ` David Gibson
2021-05-25 2:01 ` Richard Henderson
2021-05-25 3:15 ` David Gibson [this message]
2021-05-21 20:17 ` [PATCH v3 5/9] target/ppc: removed unnecessary inclusion of helper-proto.h Bruno Larsen (billionai)
2021-05-24 2:41 ` David Gibson
2021-05-21 20:17 ` [PATCH v3 6/9] target/ppc: moved ppc_cpu_do_interrupt to cpu.c Bruno Larsen (billionai)
2021-05-24 2:57 ` David Gibson
2021-05-25 2:11 ` Richard Henderson
2021-05-21 20:17 ` [PATCH v3 7/9] target/ppc: Added options to disable many TCG-only functions Bruno Larsen (billionai)
2021-05-24 3:01 ` David Gibson
2021-05-21 20:17 ` [PATCH v3 8/9] target/ppc: created tcg-stub.c file Bruno Larsen (billionai)
2021-05-24 3:02 ` David Gibson
2021-05-24 12:54 ` Bruno Piazera Larsen
2021-05-21 20:17 ` [PATCH v3 9/9] target/ppc: updated meson.build to support disable-tcg Bruno Larsen (billionai)
2021-05-25 2:13 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKxr3TXsYbh58/M4@yekko \
--to=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=fernando.valle@eldorado.org.br \
--cc=lucas.araujo@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).