From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E47FDC47082 for ; Mon, 7 Jun 2021 03:52:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6598661209 for ; Mon, 7 Jun 2021 03:52:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6598661209 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lq6JQ-0006vB-FZ for qemu-devel@archiver.kernel.org; Sun, 06 Jun 2021 23:52:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lq6Hu-0003fH-8u; Sun, 06 Jun 2021 23:50:54 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:53825 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lq6Hk-0002ch-Ac; Sun, 06 Jun 2021 23:50:54 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4Fyzt20q4dz9sSn; Mon, 7 Jun 2021 13:50:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1623037834; bh=0h8V4GRkw4VEuJQdfpzFWv+wVimI+ZJWxkcohj7VNUU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=afEDzIejIkCeke2Xgcds84P2/vbcBPV3Fd3diLvKDc/x1BwGoEH4jVfrf5darzJea ybe+zQNbf+Pv1oZwL1DXWfV0tIXkYB4pgpmCFOgErGOnoGlL40gII9t5ZmgHCWx6Ka QPkK0JubKUEU3Ol6qq4lpk/y+U5IntfbrgU1ynYk= Date: Mon, 7 Jun 2021 12:23:53 +1000 From: David Gibson To: Daniel Henrique Barboza Subject: Re: [PATCH v2 1/2] qapi/machine.json: add DEVICE_UNPLUG_ERROR QAPI event Message-ID: References: <20210604200353.1206897-1-danielhb413@gmail.com> <20210604200353.1206897-2-danielhb413@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dQbMQXWbC/Zz7A33" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --dQbMQXWbC/Zz7A33 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 07, 2021 at 12:23:08PM +1000, David Gibson wrote: > On Fri, Jun 04, 2021 at 05:03:52PM -0300, Daniel Henrique Barboza wrote: > > At this moment we only provide one event to report a hotunplug error, > > MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries > > machine is now able to report unplug errors for other device types, such > > as CPUs. > >=20 > > Instead of creating a (device_type)_UNPLUG_ERROR for each new device, > > create a generic DEVICE_UNPLUG_ERROR event that can be used by all > > unplug errors in the future. > >=20 > > Signed-off-by: Daniel Henrique Barboza >=20 > Reviewed-by: David Gibson Markus, I'm happy to take this through my tree if that's convenient for you, but I'd like to get an ack. >=20 > > --- > > qapi/machine.json | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > >=20 > > diff --git a/qapi/machine.json b/qapi/machine.json > > index 58a9c86b36..f0c7e56be0 100644 > > --- a/qapi/machine.json > > +++ b/qapi/machine.json > > @@ -1274,3 +1274,26 @@ > > ## > > { 'event': 'MEM_UNPLUG_ERROR', > > 'data': { 'device': 'str', 'msg': 'str' } } > > + > > +## > > +# @DEVICE_UNPLUG_ERROR: > > +# > > +# Emitted when a device hot unplug error occurs. > > +# > > +# @device: device name > > +# > > +# @msg: Informative message > > +# > > +# Since: 6.1 > > +# > > +# Example: > > +# > > +# <- { "event": "DEVICE_UNPLUG_ERROR" > > +# "data": { "device": "dimm1", > > +# "msg": "Memory hotunplug rejected by the guest for de= vice dimm1" > > +# }, > > +# "timestamp": { "seconds": 1615570772, "microseconds": 202844 } } > > +# > > +## > > +{ 'event': 'DEVICE_UNPLUG_ERROR', > > + 'data': { 'device': 'str', 'msg': 'str' } } >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --dQbMQXWbC/Zz7A33 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmC9gzkACgkQbDjKyiDZ s5ILNBAAyw37lRDkNn/pFM1k8LuByStFpGHg5twm5AQYzJyHY64wLeauLWvQjYZx g/uBuJ6BsSb62soPLNUjEZWbiVxQ+Jq8h9F/+Snk32YYOEBnGORuDqTueoxjT7HQ ytYFYQuZIMsfSzh3Wc/TQmX8NJKjaGIDgKCsWlb9GlGekpKsRxGO8xfMP1m5Zpe+ DE9U58q1jaoI598bbEVh9j/0PiarSaXzYiHDbAsfZ9D6IS98kL+WPX6WC7n1OgAU bpqkUkeMTddWgyH2ydht3/lduQGi7lXWW1hk5ZYwuwWo3TxQPj/q7YqVQjKJTExU 6nLerGuTgU+YMHi1Ig2TbP0OkqKMAn3qPu8shMzFsY/BkXOb/dXFShsE3eS710/V BOqaKS83ryjyKhZVviorGbz98Nx5Pq/8hQOzDGt73M6itOysjvyBPxGsismFuDkf sX8Q5Hpgbm6Cir8YSydguU4ViMVEb+lfmxxa53mZF/knFE3Tdj04NNgNXrVVhsUO GSNCWqvgQwf+jPzTM1I0xwlkPQdWaKI0U5O9lR2tF+ifV6VeDnskwptUkZm13omd YXXXLLVhKKjdYocLSvPllLDEglB1R/6TC0ciZ8UtzkNil/r4VaptwA9lXsO2CE4c NL1sY+VMwX8gQOElx6am2xJ2Np5s+DTO7CsO+EJMvzMsF+SLjLQ= =uiZS -----END PGP SIGNATURE----- --dQbMQXWbC/Zz7A33--