From: Kevin Wolf <kwolf@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: fam@euphon.net, qemu-block@nongnu.org, codyprime@gmail.com,
qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com,
mreitz@redhat.com, jsnow@redhat.com
Subject: Re: [PATCH v2 0/3] block: drop BlockDriverState::read_only
Date: Mon, 31 May 2021 16:45:50 +0200 [thread overview]
Message-ID: <YLT2ni/AiShyuVFm@merkur.fritz.box> (raw)
In-Reply-To: <20210527154056.70294-1-vsementsov@virtuozzo.com>
Am 27.05.2021 um 17:40 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Hi all!
>
> The field duplicates information in .open_flags. We have to carefully
> sync these two fields everywhere. It's simple to introduce a bug by
> forgetting it.
>
> Let's drop the field, and fix users to call bdrv_is_read_only() and
> bdrv_is_writable() instead.
>
> v2:
> 01: write "update_header =\n..." in one line
> 03: only change BlockBackendRootState, don't touch side logic
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2021-05-31 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 15:40 [PATCH v2 0/3] block: drop BlockDriverState::read_only Vladimir Sementsov-Ogievskiy
2021-05-27 15:40 ` [PATCH v2 1/3] block: consistently use bdrv_is_read_only() Vladimir Sementsov-Ogievskiy
2021-05-27 15:40 ` [PATCH v2 2/3] block: drop BlockDriverState::read_only Vladimir Sementsov-Ogievskiy
2021-05-27 15:40 ` [PATCH v2 3/3] block: drop BlockBackendRootState::read_only Vladimir Sementsov-Ogievskiy
2021-05-31 14:45 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLT2ni/AiShyuVFm@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=codyprime@gmail.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).