From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09941C47082 for ; Mon, 31 May 2021 15:47:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81BF161263 for ; Mon, 31 May 2021 15:47:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81BF161263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnk8w-00018p-LG for qemu-devel@archiver.kernel.org; Mon, 31 May 2021 11:47:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnk6v-0007zp-9W for qemu-devel@nongnu.org; Mon, 31 May 2021 11:45:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39764) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnk6n-0000Nu-Kq for qemu-devel@nongnu.org; Mon, 31 May 2021 11:45:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622475941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CYnLGhCnlXmW1Wr49da+ULxZ0briZxblVmS1U4wTXXo=; b=AwMkl1+EGD6YCaYGamnQtoRSo+TLaok1EOVWSQTz2woHvjb6kqXFYolQ2WpSzGWGpDUSfE 0tfHb6zDg+zFUKybG/ADu7ZEYH0Xf8zdPCQglhCczoGe2SJM5NsKdTyWSjVMMK1xv6bYqq rGGDgtGqfQ0NxG7etuBGG7W+Q5Cjlz0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-581-9sZfqnxCPouzbqAZ6D8U_w-1; Mon, 31 May 2021 11:45:37 -0400 X-MC-Unique: 9sZfqnxCPouzbqAZ6D8U_w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78AF2FCAC; Mon, 31 May 2021 15:45:36 +0000 (UTC) Received: from merkur.fritz.box (ovpn-114-215.ams2.redhat.com [10.36.114.215]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 38D9210023AF; Mon, 31 May 2021 15:45:34 +0000 (UTC) Date: Mon, 31 May 2021 17:45:33 +0200 From: Kevin Wolf To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v2 2/5] block-backend: improve blk_root_get_parent_desc() Message-ID: References: <20210504094510.25032-1-vsementsov@virtuozzo.com> <20210504094510.25032-3-vsementsov@virtuozzo.com> MIME-Version: 1.0 In-Reply-To: <20210504094510.25032-3-vsementsov@virtuozzo.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.372, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berto@igalia.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > We have different types of parents: block nodes, block backends and > jobs. So, it makes sense to specify type together with name. > > While being here also use g_autofree. > > iotest 307 output is updated. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Alberto Garcia > --- > block/block-backend.c | 9 ++++----- > tests/qemu-iotests/307.out | 2 +- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/block/block-backend.c b/block/block-backend.c > index 6fca9853e1..2b7e9b5192 100644 > --- a/block/block-backend.c > +++ b/block/block-backend.c > @@ -142,19 +142,18 @@ static void blk_root_set_aio_ctx(BdrvChild *child, AioContext *ctx, > static char *blk_root_get_parent_desc(BdrvChild *child) > { > BlockBackend *blk = child->opaque; > - char *dev_id; > + g_autofree char *dev_id = NULL; > > if (blk->name) { > - return g_strdup(blk->name); > + return g_strdup_printf("block device '%s'", blk->name); > } > > dev_id = blk_get_attached_dev_id(blk); > if (*dev_id) { > - return dev_id; > + return g_strdup_printf("block device '%s'", dev_id); > } else { > /* TODO Callback into the BB owner for something more detailed */ > - g_free(dev_id); > - return g_strdup("a block device"); > + return g_strdup("unnamed block device"); We should probably keep the article: "an unnamed block device" > } > } Kevin