From: David Gibson <david@gibson.dropbear.id.au>
To: Lucas Mateus Martins Araujo e Castro <lucas.araujo@eldorado.org.br>
Cc: farosas@linux.ibm.com,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, luis.pires@eldorado.org.br,
fernando.valle@eldorado.org.br, qemu-ppc@nongnu.org,
matheus.ferst@eldorado.org.br
Subject: Re: [target/ppc] excp_helper.c and mmu_helper.c cleanup
Date: Tue, 1 Jun 2021 12:34:29 +1000 [thread overview]
Message-ID: <YLWctd0j9gv+0Zie@yekko> (raw)
In-Reply-To: <5f3cd63e-92d5-56a3-89bc-519998cfe7cc@eldorado.org.br>
[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]
On Mon, May 31, 2021 at 04:21:11PM -0300, Lucas Mateus Martins Araujo e Castro wrote:
> Hi everyone,
>
> I'm working on cleaning up some of the changes to enable the disable-tcg
> option on PPC, right now focusing on target/ppc/excp_helper.c and
> target/ppc/mmu_helper.c as these files have functions that are needed in a
> !TCG build but also contains code that doesn't compile in a !TCG build, and
> currently that is dealt with #ifdef.
>
> For excp_helper.c I moved all exception handling functions to a new file
> (named target/ppc/excp_handler.c for now) and left only the helpers in it,
> and changed meson.build to always compile the new file and only compile the
> file with the helpers in a build with TCG.
That sounds reasonable.
> For mmu_helper.c the idea is to move all the code inside #ifdef CONFIG_TCG
> to another file that shouldn't be compiled in a !TCG build. But these
> changes are based on Richard Henderson's patch, so it depends if they'll be
> applied as is or there will be another version.
Ok.
> Also I'm looking into the possibility of not compiling
> ppc_tlb_invalidate_all in mmu_helper.c, but that's only possible if this
> function is not used in a !TCG build, does anyone know if this function is
> used in some corner case when running with KVM?
I'm pretty sure if ppc_tlb_invalidate_all() was ever called with KVM
that would be a bug, so that sounds sensible.
> Any opinion on these changes?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-06-01 3:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 19:21 [target/ppc] excp_helper.c and mmu_helper.c cleanup Lucas Mateus Martins Araujo e Castro
2021-06-01 2:34 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLWctd0j9gv+0Zie@yekko \
--to=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=fernando.valle@eldorado.org.br \
--cc=lucas.araujo@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).