From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7E60C4708F for ; Tue, 1 Jun 2021 19:12:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 169DB610A8 for ; Tue, 1 Jun 2021 19:12:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 169DB610A8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo9o4-0006bn-TT for qemu-devel@archiver.kernel.org; Tue, 01 Jun 2021 15:12:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo9kE-0005gg-0l; Tue, 01 Jun 2021 15:08:06 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:50409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo9kA-0001OR-OD; Tue, 01 Jun 2021 15:08:05 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 78EA85C020B; Tue, 1 Jun 2021 15:08:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 01 Jun 2021 15:08:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=GHYAwGtL/PR4nnEDDifK4Amq/T0 qfQyEBoxYMAQuHe0=; b=SS4o6g9D5S7skQOh0EOsCUCDDJM31pBIw30ym5ACWOG gsFRiQhF8LFMy2CHpFmzAcWenSQ/cPvI/TfYia7WR2vc+RIYXvjbnk64dokH+mRj CVB5EyGl0M8I0uZKbuc9f7Jyfl+e2hPyFgv/mA12YQg6z2hV9RyGV3UP49NEpAxn 0N34v69bCBqqV7QUijEHDsgMQ+0lLZ2wzHKDDAOEy+uK50NPJ23Y15S/UmI0xL9V 3huJ+sKZsGK9xNZ7mSnqT3TPYjYWgp0CgCtYWxGOlrJrI023cALRigxAXcW4DkzU dUsl5p+KA7fJhBLCl0faPKnWyGxHvhUNPec1PNbL5Gw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GHYAwG tL/PR4nnEDDifK4Amq/T0qfQyEBoxYMAQuHe0=; b=XcHlL6XEhxxk6sl9K6wEUi 34qka0vBaHJGXx0fVEojCpluyKu7+LWlSrId6F1jf1qUK3kZL9uxJ6t4p3xWV6B+ WBLKpwDFwtgEyBlV/J0ww2NC1mAr4Zi4EsvaZEwHgvzGQ5mrPrR50JbmSayx+Brd ICidXdh0BV3SId0WT4wMjXXnbZL2812K9orJDqXMKBP7/mFnqxtCP64dwHGeifhg CfZ7xWKWtRlgFlb2UfYFcc4lv/fIk9R7yJ/WPkpTKUQMXmV6i6xRQxlst/n3u6YF 5T2kKdYqgtBzbLx7+3c/MnchdQIHr6IY6uW6tUMoy0+YB9rKiPpDDZYIhk9NWhNQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdelhedgudefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepjeegudffueeiteekieelkedvueelteevjeduieeludfffeejgeffhfduvddu ffeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih htshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Jun 2021 15:07:59 -0400 (EDT) Date: Tue, 1 Jun 2021 21:07:56 +0200 From: Klaus Jensen To: Keith Busch Subject: Re: [PATCH v2 1/2] hw/nvme: add support for boot partiotions Message-ID: References: <20210601143749.1669-1-anaidu.gollu@samsung.com> <20210601143749.1669-2-anaidu.gollu@samsung.com> <20210601171936.GB4506@dhcp-10-100-145-180.wdc.com> <20210601180724.GA4527@dhcp-10-100-145-180.wdc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iM/RGiHnvucTJudX" Content-Disposition: inline In-Reply-To: <20210601180724.GA4527@dhcp-10-100-145-180.wdc.com> Received-SPF: pass client-ip=66.111.4.27; envelope-from=its@irrelevant.dk; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, kwolf@redhat.com, qemu-block@nongnu.org, Gollu Appalanaidu , qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --iM/RGiHnvucTJudX Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jun 1 11:07, Keith Busch wrote: >On Tue, Jun 01, 2021 at 07:41:34PM +0200, Klaus Jensen wrote: >> On Jun 1 10:19, Keith Busch wrote: >> > On Tue, Jun 01, 2021 at 08:07:48PM +0530, Gollu Appalanaidu wrote: >> > > NVMe Boot Partitions provides an area that may be read by the host >> > > without initializing queues or even enabling the controller. This >> > > allows various platform initialization code to be stored on the NVMe >> > > device instead of some separete medium. >> > > >> > > This patch adds the read support for such an area, as well as support >> > > for updating the boot partition contents from the host through the >> > > FW Download and Commit commands. >> > >> > Please provide some details on what platform initilization sequence >> > running on QEMU is going to make use of this feature. >> > >> >> I totally get your reluctance to accept useless features like device >> self-test and ill-supported ones like write uncorrectable. >> >> But I think this feature qualifies just fine for the device. It is useful >> for embedded development and while there might not be any qemu boards th= at >> wants to use this *right now*, it allows for experimentation. And this i= s a >> feature that actually *is* implemented by real products for embedded >> systems. > >That wasn't my request, though. I am well aware of the feature and also >have hardware that implements it. It just sounds like you haven't >actually tested this feature under the protocol's intended use cases >inside this environment. I think that type of testing and a high level >description of it in the changelog ought to be part of acceptance >criteria. > Alright, I see. You'd like to see this tested by defining a new board that loads=20 firmware over PCIe from the device? --iM/RGiHnvucTJudX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmC2hYoACgkQTeGvMW1P DekScAf+PzRvTQL0cNB8CS1wWU1W943lQDE6Nl0cA21Mwzc1k5F6gwpMC2akc5v6 tHo+W2beCAPbUnhEwOOxohTNJ5J5gT2I9oKUzNXmJRrN0RB6roOwObsFiaIh53TC YfWWd4Dyb8fhWImS83+tzBWxxNdtenjULpSabYjhW0YtzHjlQ7A6eK1xQQRHd2jZ Y6f++tg+8kmueMwZvG5bPzYi802tB6b/jixBv8YBM8LwRcbJpV3Xw78AD415kYop i0PxINbcEiaWMrQT1H55DbRQqL/TVU4SEjxQBCv83fB0AbZtirG8TuaQjA8UcW6p puPx8Z7I8WR4TJ2vfoj8WyI1hSA0Sg== =zITx -----END PGP SIGNATURE----- --iM/RGiHnvucTJudX--