Re: [PATCH] vnc: avoid deprecation warnings for SASL on OS X

["Daniel P. Berrangé" <berrange@redhat.com>]

On Fri, Jun 04, 2021 at 03:07:05PM +0200, Philippe Mathieu-Daudé wrote:
> On 6/4/21 2:09 PM, Paolo Bonzini wrote:
> > Apple has deprecated sasl.h functions in OS X 10.11.  Therefore,
> > all files that use SASL API need to disable -Wdeprecated-declarations.
> > Remove the only use that is outside vnc-auth-sasl.c and add the
> > relevant #pragma GCC diagnostic there.
> > 
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >  ui/vnc-auth-sasl.c | 20 ++++++++++++++++++++
> >  ui/vnc-auth-sasl.h |  1 +
> >  ui/vnc.c           | 10 ++--------
> >  3 files changed, 23 insertions(+), 8 deletions(-)
> > 
> > diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c
> > index df7dc08e9f..cf65a0b161 100644
> > --- a/ui/vnc-auth-sasl.c
> > +++ b/ui/vnc-auth-sasl.c
> > @@ -28,10 +28,30 @@
> >  #include "vnc.h"
> >  #include "trace.h"
> >  
> > +/*
> > + * Apple has deprecated sasl.h functions in OS X 10.11.  Therefore,
> > + * files that use SASL API need to disable -Wdeprecated-declarations.
> > + */
> > +#ifdef CONFIG_DARWIN
> > +#pragma GCC diagnostic warning "-Wdeprecated-declarations"
> > +#endif
> > +
> >  /* Max amount of data we send/recv for SASL steps to prevent DOS */
> >  #define SASL_DATA_MAX_LEN (1024 * 1024)
> >  
> >  
> > +bool vnc_sasl_server_init(Error **errp)
> > +{
> > +    int saslErr = sasl_server_init(NULL, "qemu");
> 
> What is the plan once these functions are removed for the
> distribution? Is there a replacement or should we start warning
> the users here and in docs/system/deprecated.rst VNC/SASL will
> go away soon?

VNC/SASL isn't going anywhere. It is fully supported on Linux and a
critically important security feature.

If macOS removes SASL, that sucks for macOS users, but then in that case I
assume HomeBrew/MacPorts would bring it back to life, because SASL is an
important feature for many apps.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|