From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC2E3C48BCD for ; Wed, 9 Jun 2021 17:37:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F878613BD for ; Wed, 9 Jun 2021 17:37:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F878613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lr28m-0007Pb-NR for qemu-devel@archiver.kernel.org; Wed, 09 Jun 2021 13:37:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lr28B-0006hh-Dj for qemu-devel@nongnu.org; Wed, 09 Jun 2021 13:36:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57571) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lr289-0006IL-MK for qemu-devel@nongnu.org; Wed, 09 Jun 2021 13:36:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623260201; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vhfjiTxpYMMTgdHLn4JIJD2mPuuumgwsYIX64JiZakQ=; b=Pz+UflN6M4UewEnDlgLTkt3UwLSZSnXQFxN5l9zbvi+Rgwcp8WiTlvQJ9Tsj6D+1LekHO2 T4ztkQWzEUCtFpgOOJ1KaDn7MRghiTrBuZHZ23GZzF6atThfoMzmikMehwzKib3fyqS0TV qW1CKTjmJ0q5io1ZeLzwslbgvyyiS7k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-lalxgrNYNl-JhBsDqFetTA-1; Wed, 09 Jun 2021 13:36:39 -0400 X-MC-Unique: lalxgrNYNl-JhBsDqFetTA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4F1F1012587; Wed, 9 Jun 2021 17:36:38 +0000 (UTC) Received: from redhat.com (ovpn-112-4.ams2.redhat.com [10.36.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B37695D9C6; Wed, 9 Jun 2021 17:36:36 +0000 (UTC) Date: Wed, 9 Jun 2021 18:36:33 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH] tpm: Return QMP error when TPM is disabled in build Message-ID: References: <20210609152559.1088596-1-philmd@redhat.com> <2ebcd286-cc73-e8da-53ef-2424419822ff@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , QEMU , Markus Armbruster , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jun 09, 2021 at 07:34:32PM +0200, Philippe Mathieu-Daudé wrote: > On 6/9/21 7:27 PM, Philippe Mathieu-Daudé wrote: > > On 6/9/21 6:01 PM, Marc-André Lureau wrote: > >> Hi > >> > >> On Wed, Jun 9, 2021 at 7:33 PM Philippe Mathieu-Daudé >> > wrote: > >> > >> When the management layer queries a binary built using --disable-tpm > >> for TPM devices, it gets confused by getting empty responses: > >> > >>   { "execute": "query-tpm" } > >>   { > >>       "return": [ > >>       ] > >>   } > >>   { "execute": "query-tpm-types" } > >>   { > >>       "return": [ > >>       ] > >>   } > >>   { "execute": "query-tpm-models" } > >>   { > >>       "return": [ > >>       ] > >>   } > >> > >> Make it clearer by returning an error, mentioning the feature is > >> disabled: > >> > >>   { "execute": "query-tpm" } > >>   { > >>       "error": { > >>           "class": "GenericError", > >>           "desc": "this feature or command is not currently supported" > >>       } > >>   } > >> > >> Signed-off-by: Philippe Mathieu-Daudé >> > > >> > >> > >> Why not make the qapi schema conditional? > > Using your suggestion (and ignoring QAPI marshaling error) I'm getting: > > { "execute": "query-tpm" } > { > "error": { > "class": "CommandNotFound", > "desc": "The command query-tpm has not been found" > } > } > > Is that OK from a management perspective? That's fairly typical of what we'd expect to see from a feature which is either removed at compile time, or never existed in the first place. mgmt apps don't really need to distinguish those two scenarios, so this is fine. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|