From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7EAEC48BCD for ; Wed, 9 Jun 2021 17:45:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 250746128A for ; Wed, 9 Jun 2021 17:45:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 250746128A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lr2GH-0003uJ-UZ for qemu-devel@archiver.kernel.org; Wed, 09 Jun 2021 13:45:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lr2Ej-00035n-RD for qemu-devel@nongnu.org; Wed, 09 Jun 2021 13:43:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lr2Eh-0002NJ-AA for qemu-devel@nongnu.org; Wed, 09 Jun 2021 13:43:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623260603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KXnOo7trrDnzqCWWPkzmjTQohdXLXjSAX67woLR8PR0=; b=O3QlMOl8OHlgdW6vPd9mVIr5Pp8mgz4IMG214F1DIridDBK98bavqXUz24u3+7TSOOg8wc 4tY1OmI7E7K/SrCEutdw0a7HxRcADS6zikDCZQqMz95qBMx89ryJIo94Vkbmm5m9ssWzcS 1hIFIyMsOJ1yryG7Js3X2D7uYyscrTQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-qJ8X-lS9OaKpKf3Jnx39DQ-1; Wed, 09 Jun 2021 13:43:19 -0400 X-MC-Unique: qJ8X-lS9OaKpKf3Jnx39DQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2FF311934128; Wed, 9 Jun 2021 17:43:14 +0000 (UTC) Received: from redhat.com (ovpn-114-230.ams2.redhat.com [10.36.114.230]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C15B161F2B; Wed, 9 Jun 2021 17:42:41 +0000 (UTC) Date: Wed, 9 Jun 2021 19:42:39 +0200 From: Kevin Wolf To: Eric Blake Subject: Re: [PATCH] block: Move read-only check during truncation earlier Message-ID: References: <20210609163034.997943-1-eblake@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210609163034.997943-1-eblake@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , "open list:Block I/O path" , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 09.06.2021 um 18:30 hat Eric Blake geschrieben: > No need to start a tracked request that will always fail. The choice > to check read-only after bdrv_inc_in_flight() predates 1bc5f09f2e > (block: Use tracked request for truncate), but waiting for serializing > requests can make the effect more noticeable. > > Signed-off-by: Eric Blake Thanks, applied to the block branch. Kevin