From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A057CC48BCD for ; Wed, 9 Jun 2021 13:49:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3ADD761351 for ; Wed, 9 Jun 2021 13:49:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ADD761351 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqyaN-0004cY-6c for qemu-devel@archiver.kernel.org; Wed, 09 Jun 2021 09:49:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqyZN-0003dE-7w for qemu-devel@nongnu.org; Wed, 09 Jun 2021 09:48:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26756) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqyZJ-0000ht-83 for qemu-devel@nongnu.org; Wed, 09 Jun 2021 09:48:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623246501; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TSt4vP+bHRcLuGbf0X4xiF4b+gqdBzUu6twwpNv17rU=; b=ErE/Fe9LX8/GF6Ko3FqAGL2br8QHNgrwwrucGkOXzc91/eMx0vQJ/V7dOIS0G2JVAGxmYp 0kOLbB+4K/xQ3pTuaF02PALApGcmDzORHZI69OimGehInT0pD9P3IwQuSZReXToKqeiBCg fSKTKZCQYeQicMHRsn1sBCuqrr6iPRU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-604-ik4Sx_DOPdKaVZ-C7jKbIw-1; Wed, 09 Jun 2021 09:48:14 -0400 X-MC-Unique: ik4Sx_DOPdKaVZ-C7jKbIw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C4A56195D562; Wed, 9 Jun 2021 13:48:13 +0000 (UTC) Received: from redhat.com (ovpn-115-127.ams2.redhat.com [10.36.115.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52DC418A69; Wed, 9 Jun 2021 13:48:12 +0000 (UTC) Date: Wed, 9 Jun 2021 14:48:09 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Subject: Re: [PATCH] configure: map x32 to cpu_family x86_64 for meson Message-ID: References: <878s3jrzm0.fsf@gmail.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Paolo Bonzini , Alex =?utf-8?Q?Benn=C3=A9e?= , David Michael , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jun 09, 2021 at 02:30:09PM +0100, Peter Maydell wrote: > On Wed, 9 Jun 2021 at 13:48, Daniel P. Berrangé wrote: > > > > On Wed, Jun 09, 2021 at 08:28:39AM -0400, David Michael wrote: > > > The meson.build file defines supported_cpus which does not contain > > > x32, and x32 is not one of meson's stable built-in values: > > > https://mesonbuild.com/Reference-tables.html#cpu-families > > > > > > Signed-off-by: David Michael > > > --- > > > > > > Hi, > > > > > > QEMU fails to build for x32 due to that cpu_family not being defined in > > > supported_cpus. Can something like this be applied? > > > > > > Alternatively, maybe it could be added to supported_cpus and accepted > > > everywhere that matches x86 in meson.build, but upstream meson does not > > > define a CPU type for x32. > > > > "supported_cpus" serves two distinct purposes in meson.build > > > > - Identifies whether TCG supports the target > > - Identifies whether QEMU maintainers consider the target supported > > > > The change proposed below makes x32 be treated the same as x86_64. > > I feel like it's more "fixing a regression we introduced by accident > at some point". Looking at the 5.1 configure script (which predates > the meson conversion) x32 is marked as a supported cpu. Currently it > isn't, so that's a regression. (I don't have the setup to bisect that > right now, but it would be interesting to confirm where it stopped > working.) Whether we feel that we no longer want to support x32 is > a separate question and we'd need to go through our usual deprecation > process if we did want to drop it. Ah, I missed that it was previously working. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|