From: Peter Xu <peterx@redhat.com>
To: huangy81@chinatelecom.cn
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Chuan Zheng <zhengchuan@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v7 4/7] migration/dirtyrate: introduce struct and adjust DirtyRateStat
Date: Thu, 17 Jun 2021 11:27:03 -0400 [thread overview]
Message-ID: <YMtpxwcxQgVKork7@t490s> (raw)
In-Reply-To: <d91f66916a28327105f62919092224a403a0067f.1623938622.git.huangy81@chinatelecom.cn>
On Thu, Jun 17, 2021 at 10:12:05PM +0800, huangy81@chinatelecom.cn wrote:
> ##
> +# @DirtyRateMeasureMode:
> +#
> +# An enumeration of mode of measuring dirtyrate.
> +#
> +# @page-sampling: calculate dirtyrate by sampling pages.
> +#
> +# @dirty-ring: calculate dirtyrate by via dirty ring.
> +#
> +# Since: 6.1
> +#
> +##
> +{ 'enum': 'DirtyRateMeasureMode',
> + 'data': [ 'none', 'page-sampling', 'dirty-ring'] }
I still don't get why we need "none" mode. Could you explain?
--
Peter Xu
next prev parent reply other threads:[~2021-06-17 15:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 14:12 [PATCH v7 0/7] support dirtyrate at the granualrity of vcpu huangy81
2021-06-17 14:12 ` [PATCH v7 1/7] KVM: introduce dirty_pages and kvm_dirty_ring_enabled huangy81
2021-06-17 14:12 ` [PATCH v7 2/7] memory: rename global_dirty_log to global_dirty_tracking huangy81
2021-06-17 14:12 ` [PATCH v7 3/7] memory: make global_dirty_tracking a bitmask huangy81
2021-06-17 15:29 ` Peter Xu
2021-06-18 0:36 ` Hyman Huang
2021-06-18 0:50 ` Hyman Huang
2021-06-17 14:12 ` [PATCH v7 4/7] migration/dirtyrate: introduce struct and adjust DirtyRateStat huangy81
2021-06-17 15:27 ` Peter Xu [this message]
2021-06-18 0:35 ` Hyman Huang
2021-06-17 14:12 ` [PATCH v7 5/7] migration/dirtyrate: adjust order of registering thread huangy81
2021-06-17 14:12 ` [PATCH v7 6/7] migration/dirtyrate: move init step of calculation to main thread huangy81
2021-06-17 15:34 ` Peter Xu
2021-06-18 1:16 ` Hyman Huang
2021-06-17 14:12 ` [PATCH v7 7/7] migration/dirtyrate: implement dirty-ring dirtyrate calculation huangy81
2021-06-17 15:41 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMtpxwcxQgVKork7@t490s \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=huangy81@chinatelecom.cn \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).