From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D11BFC2B9F4 for ; Thu, 17 Jun 2021 15:27:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51603611CE for ; Thu, 17 Jun 2021 15:27:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51603611CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lttvp-0006Nl-5g for qemu-devel@archiver.kernel.org; Thu, 17 Jun 2021 11:27:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lttvE-0005jI-KD for qemu-devel@nongnu.org; Thu, 17 Jun 2021 11:27:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:50081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lttvB-0001ug-19 for qemu-devel@nongnu.org; Thu, 17 Jun 2021 11:27:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623943627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MnX/6PAv3kzqhUVvZoSFhpW7sakhKgisrslFxIEGcBs=; b=EbK9fgZ4h1U276ROTbjsiOwnAul9qS6A0OH5M6Cfh4BjkHm2b4l0KFjQeJ94XTOGAT0Ind /7+hHgG+B1t/gSRkczWAEdoroJPPZ6VwoEcW+ebjSaJxRB0JIEy8I1X6BYN1PpT6VSpXko tbzJI8FNmefJg6hyYQpHf/04FJXV1C8= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-oGsPEG8YNLKfB0uEIs1IMQ-1; Thu, 17 Jun 2021 11:27:06 -0400 X-MC-Unique: oGsPEG8YNLKfB0uEIs1IMQ-1 Received: by mail-qk1-f199.google.com with SMTP id 205-20020a3707d60000b02903aa9208caa2so2316664qkh.13 for ; Thu, 17 Jun 2021 08:27:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MnX/6PAv3kzqhUVvZoSFhpW7sakhKgisrslFxIEGcBs=; b=LDoc7L74INug32EiAkEW3MgLsYeL2g0j0s9HUlJeR9ArwCD3MvqoS4kPX8y9ojj963 ZF/GMPJHbnI2TdBSKRpnIKVPF5ABrXKhOxAV3HNcPyppH/Jl3a59BiGGHOPuYoJuJa86 eB0Zoy7zhRirx+ydbqC3ngic/byGexxzQ8NATCQRGLlD2dWBCQ16qwiLJ376bwvN0Z0Z ZfmttCDzQboVryfaUg7rR8Q5qY0Mg69LXj74EkOSKnMpwnsgq5v7eIET6MfpjTNawQ9u SKc2zJRT+XCS2Q6bLkePo3G1oLRSVCAkBKiLnH/sw/KrY9B3yLGnk8bckrifjpwjPuyh sf1w== X-Gm-Message-State: AOAM531orO8SQo+E711fsNtT+sInZviwZTxCDSn1lykcsuCLVbU1cYDB mSKE53Gn1hBDXI/gd6+duxWvh6hGXDJVtMWiWPF3VB4ZhNknsZPX+lJ4EQZlLtdGRPxjdoBQSx1 NZwUj0zfLhSN1CnI= X-Received: by 2002:a05:6214:1551:: with SMTP id t17mr355149qvw.50.1623943625581; Thu, 17 Jun 2021 08:27:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZDigkQ/AFcRsi+8sqnr/08h2I0070lHS7U9WJ48+P+BKJKtJ0ggKOh+h+OY8MSfZX++teRw== X-Received: by 2002:a05:6214:1551:: with SMTP id t17mr355132qvw.50.1623943625391; Thu, 17 Jun 2021 08:27:05 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-65-184-144-111-238.dsl.bell.ca. [184.144.111.238]) by smtp.gmail.com with ESMTPSA id 20sm1897781qky.124.2021.06.17.08.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 08:27:04 -0700 (PDT) Date: Thu, 17 Jun 2021 11:27:03 -0400 From: Peter Xu To: huangy81@chinatelecom.cn Subject: Re: [PATCH v7 4/7] migration/dirtyrate: introduce struct and adjust DirtyRateStat Message-ID: References: MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.197, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Juan Quintela , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Chuan Zheng , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 17, 2021 at 10:12:05PM +0800, huangy81@chinatelecom.cn wrote: > ## > +# @DirtyRateMeasureMode: > +# > +# An enumeration of mode of measuring dirtyrate. > +# > +# @page-sampling: calculate dirtyrate by sampling pages. > +# > +# @dirty-ring: calculate dirtyrate by via dirty ring. > +# > +# Since: 6.1 > +# > +## > +{ 'enum': 'DirtyRateMeasureMode', > + 'data': [ 'none', 'page-sampling', 'dirty-ring'] } I still don't get why we need "none" mode. Could you explain? -- Peter Xu