From: Klaus Jensen <k.jensen@samsung.com>
To: Keith Busch <kbusch@kernel.org>
Cc: "Klaus Jensen" <its@irrelevant.dk>,
"Jakub Jermář" <jakub.jermar@kernkonzept.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] hw/nvme: fix pin-based interrupt behavior (again)
Date: Thu, 17 Jun 2021 20:48:30 +0200 [thread overview]
Message-ID: <YMuY/k0exA4onXCI@apples.localdomain> (raw)
In-Reply-To: <20210617145019.GB1133213@dhcp-10-100-145-180.wdc.com>
On Jun 17 07:50, Keith Busch wrote:
>On Thu, Jun 17, 2021 at 12:08:20PM +0200, Klaus Jensen wrote:
>> if (cq->tail != cq->head) {
>> + if (!pending) {
>> + n->cq_pending++;
>> + }
>
>You should check cq->irq_enabled before incrementing cq_pending. You
>don't want to leave the irq asserted when polled queues have outsanding
>CQEs.
Good catch. Thanks!
prev parent reply other threads:[~2021-06-17 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 10:08 [PATCH] hw/nvme: fix pin-based interrupt behavior (again) Klaus Jensen
2021-06-17 10:09 ` Klaus Jensen
2021-06-17 13:24 ` Jakub Jermář
2021-06-17 14:50 ` Keith Busch
2021-06-17 18:48 ` Klaus Jensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMuY/k0exA4onXCI@apples.localdomain \
--to=k.jensen@samsung.com \
--cc=its@irrelevant.dk \
--cc=jakub.jermar@kernkonzept.com \
--cc=kbusch@kernel.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).