From: Peter Xu <peterx@redhat.com>
To: Hyman <huangy81@chinatelecom.cn>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Chuan Zheng <zhengchuan@huawei.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v8 2/6] memory: make global_dirty_tracking a bitmask
Date: Fri, 18 Jun 2021 12:42:03 -0400 [thread overview]
Message-ID: <YMzM23e0prMLW5B2@t490s> (raw)
In-Reply-To: <2693c2a4-29f0-e196-c97c-985584c19419@chinatelecom.cn>
On Sat, Jun 19, 2021 at 12:16:49AM +0800, Hyman wrote:
>
>
> 在 2021/6/18 23:46, Peter Xu 写道:
> > On Fri, Jun 18, 2021 at 11:32:03PM +0800, huangy81@chinatelecom.cn wrote:
> > > diff --git a/include/exec/memory.h b/include/exec/memory.h
> > > index b114f54..dd2404f 100644
> > > --- a/include/exec/memory.h
> > > +++ b/include/exec/memory.h
> > > @@ -55,7 +55,17 @@ static inline void fuzz_dma_read_cb(size_t addr,
> > > }
> > > #endif
> > > -extern bool global_dirty_log;
> > > +/* Possible bits for global_dirty_log */
> >
> > s/log/tracking/
> here, we just rename global_dirty_log to global_dirty_tracking, but the
> function name remain the same? such as:
> memory_global_dirty_log_start/memory_global_dirty_log_stop
Then you may want to write it as:
/* Possible bits for memory_global_dirty_log_{start|stop} */
It's a trivial nitpicking, I don't have a strong opinion here.. Before any
other's comments, please feel free to choose anything. Thanks,
--
Peter Xu
next prev parent reply other threads:[~2021-06-18 16:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 15:32 [PATCH v8 0/6] support dirtyrate at the granualrity of vcpu huangy81
2021-06-18 15:32 ` [PATCH v8 1/6] KVM: introduce dirty_pages and kvm_dirty_ring_enabled huangy81
2021-06-18 15:32 ` [PATCH v8 2/6] memory: make global_dirty_tracking a bitmask huangy81
2021-06-18 15:46 ` Peter Xu
2021-06-18 16:02 ` Hyman
2021-06-18 16:16 ` Hyman
2021-06-18 16:42 ` Peter Xu [this message]
2021-06-18 15:32 ` [PATCH v8 3/6] migration/dirtyrate: introduce struct and adjust DirtyRateStat huangy81
2021-06-18 15:32 ` [PATCH v8 4/6] migration/dirtyrate: adjust order of registering thread huangy81
2021-06-18 15:32 ` [PATCH v8 5/6] migration/dirtyrate: move init step of calculation to main thread huangy81
2021-06-18 15:32 ` [PATCH v8 6/6] migration/dirtyrate: implement dirty-ring dirtyrate calculation huangy81
2021-06-18 16:00 ` [PATCH v8 0/6] support dirtyrate at the granualrity of vcpu Peter Xu
2021-06-18 16:36 ` Hyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMzM23e0prMLW5B2@t490s \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=huangy81@chinatelecom.cn \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).